Add isNotInstanceOfAny assertion#352
Open
aymericcucherousset wants to merge 2 commits intowebmozarts:masterfrom
Open
Add isNotInstanceOfAny assertion#352aymericcucherousset wants to merge 2 commits intowebmozarts:masterfrom
aymericcucherousset wants to merge 2 commits intowebmozarts:masterfrom
Conversation
shadowhand
requested changes
Apr 5, 2026
src/Assert.php
Outdated
Comment on lines
+556
to
+562
| * @template T of object | ||
| * | ||
| * @psalm-assert T $value | ||
| * | ||
| * @param T $value | ||
| * | ||
| * @return T |
Collaborator
There was a problem hiding this comment.
I don't believe this is correct, because there is no reason that $value has to be an object at all. For instance:
Assert::isNotInstanceOfAny(null, ['stdClass']); // true
Assert::isNotInstanceOfAny([42], ['stdClass']); // true
Assert::isNotInstanceOfAny(false, ['stdClass']); // true
Author
There was a problem hiding this comment.
You were right, there was no guarantee that values were objects.
I removed the of object constraint to reflect the actual behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #270