Skip to content

refactor(template): convert the default template from CMJs to esm #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThierryRakotomanana wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(template): convert the default template from CMJs to esm #4709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60118cc
refactor(template): convert the default template from CMJs to esm
ThierryRakotomanana Mar 18, 2026
92d8f3f
test: update snapshots for ESM default config template
ThierryRakotomanana Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/create-webpack-app/templates/init/default/webpack.config.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');<% if (htmlWebpackPlugin) { %>
const HtmlWebpackPlugin = require('html-webpack-plugin');<% } %><% if (extractPlugin !== 'No') { %>
const MiniCssExtractPlugin = require('mini-css-extract-plugin');<% } %><% if (workboxWebpackPlugin) { %>
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');<% } %>
import path from "node:path";
import { fileURLToPath } from "node:url";<% if (htmlWebpackPlugin) { %>
import HtmlWebpackPlugin from 'html-webpack-plugin';<% } %><% if (extractPlugin !== 'No') { %>
import MiniCssExtractPlugin from 'mini-css-extract-plugin';<% } %><% if (workboxWebpackPlugin) { %>
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';<% } %>

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';
<% if (cssType !== 'none') { %>
<% if (extractPlugin === "Yes") { %>
Expand Down Expand Up @@ -86,7 +89,7 @@ const config = {
},<% } %>
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';
<% if (extractPlugin === "Only for Production") { %>
Expand Down
114 changes: 75 additions & 39 deletions test/create-webpack-app/init/__snapshots__/init.test.js.snap.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,11 @@ exports[`create-webpack-app cli should configure WDS as opted 1`] = `
exports[`create-webpack-app cli should configure WDS as opted 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
import path from "node:path";
import { fileURLToPath } from "node:url";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -99,7 +102,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -134,9 +137,12 @@ exports[`create-webpack-app cli should configure html-webpack-plugin as opted 1`
exports[`create-webpack-app cli should configure html-webpack-plugin as opted 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -172,7 +178,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -208,10 +214,13 @@ exports[`create-webpack-app cli should configure workbox-webpack-plugin as opted
exports[`create-webpack-app cli should configure workbox-webpack-plugin as opted 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -247,7 +256,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -285,8 +294,11 @@ exports[`create-webpack-app cli should generate ES6 project correctly 1`] = `
exports[`create-webpack-app cli should generate ES6 project correctly 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
import path from "node:path";
import { fileURLToPath } from "node:url";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -318,7 +330,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -356,10 +368,13 @@ exports[`create-webpack-app cli should generate default project when nothing is
exports[`create-webpack-app cli should generate default project when nothing is passed 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -399,7 +414,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -439,10 +454,13 @@ exports[`create-webpack-app cli should generate default project when nothing is
exports[`create-webpack-app cli should generate default project when nothing is passed and handle conflicts 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -482,7 +500,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -520,10 +538,13 @@ exports[`create-webpack-app cli should generate default project when nothing is
exports[`create-webpack-app cli should generate default project when nothing is passed and handle conflicts 4`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -563,7 +584,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -603,10 +624,13 @@ exports[`create-webpack-app cli should generate default project when nothing is
exports[`create-webpack-app cli should generate default project when nothing is passed and override when content exist 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -646,7 +670,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -686,10 +710,13 @@ exports[`create-webpack-app cli should generate default project when nothing is
exports[`create-webpack-app cli should generate default project when nothing is passed and override when content exist 4`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const WorkboxWebpackPlugin = require('workbox-webpack-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import HtmlWebpackPlugin from 'html-webpack-plugin';
import WorkboxWebpackPlugin from 'workbox-webpack-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -729,7 +756,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -1054,8 +1081,11 @@ exports[`create-webpack-app cli should generate typescript project correctly 1`]
exports[`create-webpack-app cli should generate typescript project correctly 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
import path from "node:path";
import { fileURLToPath } from "node:url";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -1091,7 +1121,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -1255,9 +1285,12 @@ exports[`create-webpack-app cli should use css preprocessor and css with postcss
exports[`create-webpack-app cli should use css preprocessor and css with postcss in project when selected 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import MiniCssExtractPlugin from 'mini-css-extract-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -1297,7 +1330,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down Expand Up @@ -1340,9 +1373,12 @@ exports[`create-webpack-app cli should use to use css preprocessor with postcss
exports[`create-webpack-app cli should use to use css preprocessor with postcss with mini-css-extract-plugin in project when selected 2`] = `
"// Generated using webpack-cli https://github.com/webpack/webpack-cli

const path = require('path');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
import path from "node:path";
import { fileURLToPath } from "node:url";
import MiniCssExtractPlugin from 'mini-css-extract-plugin';

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const isProduction = process.env.NODE_ENV === 'production';


Expand Down Expand Up @@ -1378,7 +1414,7 @@ const config = {
},
};

module.exports = () => {
export default () => {
if (isProduction) {
config.mode = 'production';

Expand Down
Loading