Skip to content

fix(init): resolve localhost IP family for devServer allowedHosts #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ThierryRakotomanana wants to merge 1 commit into from
+65 −4
Closed

fix(init): resolve localhost IP family for devServer allowedHosts #4715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/create-webpack-app/templates/init/default/webpack.config.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ import { fileURLToPath } from "node:url";<% if (htmlWebpackPlugin) { %>
import HtmlWebpackPlugin from "html-webpack-plugin";<% } %><% if (extractPlugin !== "No") { %>
import MiniCssExtractPlugin from "mini-css-extract-plugin";<% } %><% if (workboxWebpackPlugin) { %>
import WorkboxWebpackPlugin from "workbox-webpack-plugin";<% } %>
<% const { execFileSync } = await import("node:child_process");
let host;
try {
const family = execFileSync(process.execPath, [
"--input-type=module",
"--eval",
`import dns from "node:dns/promises";
const { family } = await dns.lookup("localhost");
process.stdout.write(String(family));`
], { encoding: "utf8", timeout: 3000 }).trim();
host = family === "6" ? "::1" : "127.0.0.1";
} catch { host = null; } %>

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand All @@ -27,7 +39,8 @@ const config = {
},<% if (devServer) { %>
devServer: {
open: true,
host: "localhost",
host: "localhost",<% if (host) { %>
allowedHosts: ["<%= host %>"],<% } %>
},<% } %>
plugins: [<% if (htmlWebpackPlugin) { %>
new HtmlWebpackPlugin({
Expand Down
15 changes: 14 additions & 1 deletion packages/create-webpack-app/templates/init/react/webpack.config.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ import { fileURLToPath } from "node:url";<% if (htmlWebpackPlugin) { %>
import HtmlWebpackPlugin from "html-webpack-plugin";<% } %><% if (extractPlugin !== "No") { %>
import MiniCssExtractPlugin from "mini-css-extract-plugin";<% } %><% if (workboxWebpackPlugin) { %>
import WorkboxWebpackPlugin from "workbox-webpack-plugin";<% } %>
<% const { execFileSync } = await import("node:child_process")
let host;
try {
const family = execFileSync(process.execPath, [
"--input-type=module",
"--eval",
`import dns from "node:dns/promises";
const { family } = await dns.lookup("localhost");
process.stdout.write(String(family));`
], { encoding: "utf8", timeout: 3000 }).trim();
host = family === "6" ? "::1" : "127.0.0.1";
} catch { host = null; } %>

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand All @@ -27,7 +39,8 @@ const config = {
},<% if (devServer) { %>
devServer: {
open: true,
host: "localhost",
host: "localhost",<% if (host) { %>
allowedHosts: ["<%= host %>"],<% } %>
},<% } %>
plugins: [<% if (htmlWebpackPlugin) { %>
new HtmlWebpackPlugin({
Expand Down
15 changes: 14 additions & 1 deletion packages/create-webpack-app/templates/init/svelte/webpack.config.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,18 @@ import { fileURLToPath } from "node:url";<% if (htmlWebpackPlugin) { %>
import HtmlWebpackPlugin from "html-webpack-plugin";<% } %><% if (extractPlugin !== "No") { %>
import MiniCssExtractPlugin from "mini-css-extract-plugin";<% } %><% if (workboxWebpackPlugin) { %>
import WorkboxWebpackPlugin from "workbox-webpack-plugin";<% } %>
<% const { execFileSync } = await import("node:child_process")
let host;
try {
const family = execFileSync(process.execPath, [
"--input-type=module",
"--eval",
`import dns from "node:dns/promises";
const { family } = await dns.lookup("localhost");
process.stdout.write(String(family));`
], { encoding: "utf8", timeout: 3000 }).trim();
host = family === "6" ? "::1" : "127.0.0.1";
} catch { host = null; } %>

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand All @@ -27,7 +39,8 @@ const config = {
},<% if (devServer) { %>
devServer: {
open: true,
host: "localhost",
host: "localhost",<% if (host) { %>
allowedHosts: ["<%= host %>"],<% } %>
},<% } %>
plugins: [<% if (htmlWebpackPlugin) { %>
new HtmlWebpackPlugin({
Expand Down
15 changes: 14 additions & 1 deletion packages/create-webpack-app/templates/init/vue/webpack.config.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ import { fileURLToPath } from "node:url";<% if (htmlWebpackPlugin) { %>
import HtmlWebpackPlugin from "html-webpack-plugin";<% } %><% if (extractPlugin !== "No") { %>
import MiniCssExtractPlugin from "mini-css-extract-plugin";<% } %><% if (workboxWebpackPlugin) { %>
import WorkboxWebpackPlugin from "workbox-webpack-plugin";<% } %>
<% const { execFileSync } = await import("node:child_process")
let host;
try {
const family = execFileSync(process.execPath, [
"--input-type=module",
"--eval",
`import dns from "node:dns/promises";
const { family } = await dns.lookup("localhost");
process.stdout.write(String(family));`
], { encoding: "utf8", timeout: 3000 }).trim();
host = family === "6" ? "::1" : "127.0.0.1";
} catch { host = null; } %>

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
Expand All @@ -28,7 +40,8 @@ const config = {
},<% if (devServer) { %>
devServer: {
open: true,
host: "localhost",
host: "localhost",<% if (host) { %>
allowedHosts: ["<%= host %>"],<% } %>
},<% } %>
plugins: [
new VueLoaderPlugin(),<% if (htmlWebpackPlugin) { %>
Expand Down
9 changes: 9 additions & 0 deletions test/create-webpack-app/init/__snapshots__/init.test.js.snap.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
// Add your plugins here
Expand Down Expand Up @@ -394,6 +395,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -481,6 +483,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -566,6 +569,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -653,6 +657,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -740,6 +745,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -891,6 +897,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -1010,6 +1017,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new HtmlWebpackPlugin({
Expand Down Expand Up @@ -1221,6 +1229,7 @@ const config = {
devServer: {
open: true,
host: "localhost",
allowedHosts: ["::1"],
},
plugins: [
new VueLoaderPlugin(),
Expand Down
Loading