fix: rename __namedParameters to meaningful parameter names#29
Closed
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Closed
fix: rename __namedParameters to meaningful parameter names#29TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
TusharThakur04 wants to merge 1 commit intowebpack:mainfrom
Conversation
Member
|
While I appreciate the intent here, we are trying to save the bulk of this work for GSoC. We got the fundamental workings down (basic pipeline), but a lot of the work here is for GSoC, which has not begun. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames default __namedParameters to meaningful param names
(last word of type name)Earlier:
deserialize(__namedParameters)__namedParameters{ObjectDeserializerContext}After:
deserialize(context)context{ObjectDeserializerContext}What kind of change does this PR introduce?
fix
Did you add tests for your changes?
no
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI
used ai for insight, discussion and faster code production.