fix(build): prevent rimraf glob crash on Windows by injecting --glob …#8130
Merged
alexander-akait merged 2 commits intowebpack:mainfrom Mar 27, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexander-akait
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit a terminal crash when trying to run npm run build locally on Windows.
The clean-printable and clean scripts throw an EINVAL (Illegal characters) error because rimraf ^6 stops globbing by default and relies on the Unix shell to expand **. On Windows, cmd passes ** literally, which causes fs.rm to crash instantly.
Adding the explicit --glob flag to these scripts lets rimraf handle the wildcards internally, fixing the build crash completely for Windows contributors.
What kind of change does this PR introduce?
build / fix
Did you add tests for your changes?
N/A (This restores the ability for Windows users to execute the existing build scripts).
Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
N/A
Use of AI
Debugged locally from a custom Windows development environment.