Skip to content

fix: resolve dark theme for mobile-sidebar #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 1 commit into from
Mar 30, 2026
+5 −24
Merged

fix: resolve dark theme for mobile-sidebar #8133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/components/SidebarMobile/SidebarMobile.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default class SidebarMobile extends Component {
onTouchEnd={this._handleTouchEnd}
/>

<div className="relative w-[285px] h-screen overflow-x-hidden py-1 bg-white shadow-[0_0_15px_rgba(0,0,0,0.2)]">
<div className="relative w-[285px] h-screen overflow-x-hidden py-1 bg-white dark:bg-[#121212] shadow-[0_0_15px_rgba(0,0,0,0.2)]">
<button
className="sidebar-mobile__close absolute cursor-pointer border-none right-[22px] top-[10px] text-[1.3em] bg-[#175d96] text-white w-[30px] h-[30px] flex items-center justify-center rounded-full transition-colors duration-150 [-webkit-tap-highlight-color:transparent] hover:bg-[#135d96]"
onClick={toggle.bind(null, false)}
Expand Down Expand Up @@ -93,7 +93,8 @@ export default class SidebarMobile extends Component {
className={clsx(
"uppercase pt-[0.75em] px-4 pb-[0.25em] font-semibold block text-[1.1rem]",
active ? "text-[#465E69]" : "text-[#2B3A42]",
index > 0 && "border-t border-gray-200",
index > 0 && "border-t border-gray-200 dark:border-[#343434]",
"dark:text-[#cadbe6]",
)}
key={section.url}
to={section.url}
Expand Down Expand Up @@ -131,8 +132,8 @@ export default class SidebarMobile extends Component {
className={clsx(
"block py-[0.5em] px-[17px] capitalize [-webkit-tap-highlight-color:transparent] ml-[20px]",
active
? "text-gray-900 font-semibold bg-[#f1f4f4]"
: "text-gray-600 hover:text-gray-600 active:text-gray-900 active:font-semibold active:bg-[#f1f4f4]",
? "text-gray-900 font-semibold bg-[#f1f4f4] dark:text-white dark:bg-[#222424]"
: "text-gray-600 dark:text-[#a3a3a3] hover:text-gray-600 active:text-gray-900 active:font-semibold active:bg-[#f1f4f4] dark:active:bg-[#222424] dark:active:text-white",
)}
to={url}
onClick={this.props.toggle.bind(null, false)}
Expand Down
20 changes: 0 additions & 20 deletions src/styles/dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,26 +127,6 @@
}
}

// Mobile
.sidebar-mobile__content {
background-color: #121212;
}
.sidebar-mobile__section-header {
color: #cadbe6;
}
.sidebar-mobile__page {
color: #a3a3a3;
}
.sidebar-mobile__page--active,
.sidebar-mobile__page:active {
background-color: #222424;
}
.sidebar-mobile__content
div:not(:first-of-type)
.sidebar-mobile__section-header {
border-color: #343434;
}

.footer-openjsf-logo {
filter: invert(1);
}
Expand Down
Loading