Skip to content

fix: resources_generator.py with no frontends #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assafgi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resources_generator.py with no frontends #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion install/resources_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,10 @@ def _get_next_base_port(self, role):
return current_port

def _set_containers(self, role):
num_containers = self.num_containers_by_role[role]
if num_containers == 0:
return

if role == FRONTEND_ROLE:
nodes = self.frontend_nodes[:]
elif role == DRIVE_ROLE:
Expand All @@ -579,7 +583,6 @@ def _set_containers(self, role):
failure_domain = "" if self.args.use_auto_failure_domain else get_failure_domain_based_on_nodename()

num_nodes = len(nodes)
num_containers = self.num_containers_by_role[role]
average_nodes_per_container = int(num_nodes / num_containers)
logger.debug(f"average nodes per container for {role}: {average_nodes_per_container}")
num_nodes_by_container = dict() # key is container number
Expand Down
Loading