fix: add client-side challenge expiration validation#233
Open
JasonOA888 wants to merge 1 commit intowevm:mainfrom
Open
fix: add client-side challenge expiration validation#233JasonOA888 wants to merge 1 commit intowevm:mainfrom
JasonOA888 wants to merge 1 commit intowevm:mainfrom
Conversation
Adds early rejection of expired challenges on the client side, before attempting to create credentials. This improves UX by failing fast with a clear error instead of wasting user time on wallet interactions that will be rejected by the server. Two code paths now validate expiration: 1. Fetch.from() - auto-402 interceptor, after challenge matching 2. Mppx.createCredential() - manual API, after challenge parsing Both throw PaymentExpiredError (already defined in Errors.ts) when challenge.expires is set and in the past. This mirrors the existing server-side validation at src/server/Mppx.ts:359-367. Fixes wevm#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #198
Problem
When a client receives a Challenge with an
expirestimestamp that has already passed, the client still attempts to create a credential and make the payment. This results in:The server already validates expiration (
src/server/Mppx.ts:359-367), but by then the client has already connected wallet and signed transactions.Solution
Adds client-side expiration validation at two code paths:
Fetch.from()- auto-402 interceptor, after challenge matchingMppx.createCredential()- manual API, after challenge parsingBoth throw
PaymentExpiredError(already defined inErrors.ts) whenchallenge.expiresis set and in the past.Changes
Testing
Impact