fix: add memo and splits to challenge scope binding#234
Open
brendanjryan wants to merge 1 commit intomainfrom
Open
fix: add memo and splits to challenge scope binding#234brendanjryan wants to merge 1 commit intomainfrom
brendanjryan wants to merge 1 commit intomainfrom
Conversation
Prevents cross-route credential replay where a credential issued for a no-splits (or no-memo) route is accepted on a route that requires splits or a specific memo. The methodDetails fields memo and splits now participate in the scope comparison alongside amount, currency, and recipient.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents cross-route credential replay where a credential issued for a no-splits (or no-memo) route is accepted on a route that requires splits or a specific memo.
The
methodDetailsfieldsmemoandsplitsnow participate in the scope comparison alongsideamount,currency, andrecipient.Changes
server/Mppx.ts: Addmemoandsplitsto the cross-route challenge scope checkserver/Mppx.test.ts: Add test for no-splits credential replayed at splits route