Open
Conversation
In 9502163 and 03a9b39 we implemented batch updates from on_<name> change handlers. This caused a change handler that set multiple states to be changed to not trigger a render multiple times. This behaviour was not implemented for event handlers. This commit implements this behaviour for event handlers as well.
iisakkirotko
approved these changes
Jan 23, 2025
Collaborator
iisakkirotko
left a comment
iisakkirotko
left a comment
There was a problem hiding this comment.
Happy to see it makes the ipyvue code simpler
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jan 28, 2025
See widgetti/reacton#42 Solara is already compatible with it, but the tests were not. We might want to test this in CI, before releasing Solara 2.0
maartenbreddels
added a commit
to widgetti/solara
that referenced
this pull request
Jan 29, 2025
See widgetti/reacton#42 Solara is already compatible with it, but the tests were not. We might want to test this in CI, before releasing Solara 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 9502163 and 03a9b39 we implemented batch updates from on_ change handlers. This caused a change handler that set multiple states to be changed to not trigger a render multiple times. This behaviour was not implemented for event handlers. This commit implements this behaviour for event handlers as well.