Merged
Conversation
julialongtin
reviewed
Mar 9, 2026
julialongtin
approved these changes
Mar 9, 2026
bin/helm-operations.sh
Outdated
| TARGET_SYSTEM="${TARGET_SYSTEM:-example.com}" | ||
| CERT_MASTER_EMAIL="certmaster@${CERT_MASTER_EMAIL}:-certmaster@${TARGET_SYSTEM}" | ||
|
|
||
| # DEPLOY_CERT_MANAGER env variable to decide to check if cert_manager and nginx-ingress-services charts should get deployed |
Member
There was a problem hiding this comment.
this comment is a bit unclear / misphrased.
| image: | ||
| repository: docker.io/bitnamilegacy/nginx | ||
| pullPolicy: IfNotPresent | ||
| tag: "1.27.3-debian-12-r5" |
Member
There was a problem hiding this comment.
Should we be specifying a tag in examples? sounds like a way to carry around a bad version, because of cargo-culting...
Contributor
Author
There was a problem hiding this comment.
The attempt here is to avoid the exact sha256 mentioned here https://github.com/wireapp/wire-avs-service/blob/release-5.0/charts/sftd/values.yaml#L88 but keep the tag
Contributor
Author
There was a problem hiding this comment.
wireapp/wire-avs-service#40 - created a PR to get it fixed upstream
mohitrajain
force-pushed
the
fix-wiab-stag-feedback
branch
from
d47ae96 to
758427b
Compare
julialongtin
approved these changes
Mar 26, 2026
…r-ns namespace and limit log lines
…ind hashbased images
… the wiab-staging artifact hash
…ging based on review
* fix: wpb-23988 sync offline-secrets and prod-secrets.example.yaml and add comments * fix: wpb-23988 enable postgresql secret for background-worker inwiab-dev * fix: wpb-23988 sync wire-server helm chart values for wiab-dev from prod values * fix: wpb-23988 sync wire-server helm chart secrets for wiab-dev from prod values for 5.25 * fix: wpb-23988 add a changelog file * fix: wpb-23988 fix the changelog verification workflow to consider the non-master branches as well * fix: wpb-23988 remove the changelog trigger for every push operation * fix: wpb-23988 comment out empty mls secrets for wiab-dev * fix: wpb-23988 update wiab-stag artifact hash * fix: wpb-22988 fix minio service name * Update values/wire-server/demo-values.example.yaml Co-authored-by: Sukanta <amisukanta02@gmail.com> --------- Co-authored-by: Sukanta <amisukanta02@gmail.com>
Co-authored-by: Julia Longtin <julia.longtin@wire.com>
mohitrajain
force-pushed
the
fix-wiab-stag-feedback
branch
from
48a7792 to
c51ad4c
Compare
* fix: wpb-23988 sync wire-server helm chart values for wiab-dev from prod values * fix: wpb-23988 fix the changelog verification workflow to consider the non-master branches as well * fix: wpb-23988 remove the changelog trigger for every push operation * add: wpb-23988 variable private_deployment with default true to disable SNAT on adminhost * fix: wpb-23988 cert_master_email env var * fix: wpb-23988 running wiab-staging-nftables.yaml playbook is explicit * fix: wpb-23988 wiab-staging.md documentation to add details about default SNAT access being denied and how to enable it * fix: wpb-23988 add changelog * fix: wpb-23988 update the wiab-staging.md to improve documentation around running commands * fix: wpb-23988 update the artifact hash * Apply suggestions from code review Co-authored-by: Julia Longtin <julia.longtin@gmail.com> * fix: wpb-24291 update the documentation for wiab-staging * fix wpb-24291: fix the minio endpoint for s3 endpoint * fix wpb-23988: fix the logic in wiab_server_nftables.conf.j2 and update the inventory comment * fix wpb-23988: upgrade documentation and small fixes for inventory * Wpb 23988 disable smallstep (#882) * fix: wpb-23988 update the wiab-staging.md to improve documentation around running commands * fix: wpb-23988 stop deploying smallstep by default in wiab-staging and wiab-dev * fix: wpb-23988 changelog * fix wpb-23988: replace demo-smtp with smtp * fix wpb-23988: push action on master branch only * fix wpb-23988: update documentation based on wire-docs pr101 --------- Co-authored-by: Julia Longtin <julia.longtin@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: debug_logs.sh to log only the pods for default and cert-manager-ns namespace and limit log lines
Added: enabled debug_logs.sh on helm install failures (helm_operations.sh) with a flag DUMP_LOGS_ON_FAIL
Added: env vars to helm_operations.sh to improve UX while configuring variables
Fixed: sync_pg_secrets operation in helm_operations.sh and clean the deploy_charts logic
Added: wait and timeout on cert-manager and calling_services helm chart operations
Fixed: offline-cluster.sh to run helm-operations.sh using new env vars and with default DUMP_LOGS_ON_FAIL=TRUE
Fixed: documentation for wiab-staging.md based on a user feedback
Fixed: sftd helm chart values for joinCall component which fails to find hashbased images
Change type
Basic information
Testing
Offline Build CI (label-based)
Add one or more labels to trigger offline builds:
build-default- Full production build (ansible, terraform, all packages)build-demo- Demo/WIAB buildbuild-wiab-staging- WIAB-staging buildbuild-min- Minimal build (fastest, essential charts only)build-all- Run all three buildsNote: No builds run by default. Add a label to trigger CI.
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case