Skip to content

fix: Use small file cards when no preview is available(WPB-23340)#20361

Merged
arjita-mitra merged 3 commits intodevfrom
bugfix/nonpreview-variant-smallcard/WPB-23340
Feb 10, 2026
Merged

fix: Use small file cards when no preview is available(WPB-23340)#20361
arjita-mitra merged 3 commits intodevfrom
bugfix/nonpreview-variant-smallcard/WPB-23340

Conversation

@arjita-mitra
Copy link
Copy Markdown
Contributor

@arjita-mitra arjita-mitra commented Feb 9, 2026

TaskWPB-23340 [Web] Non-preview Enabled files are displaying as big card with an error

Pull Request

Summary

  • Whenever we upload one “lambda” file type that does not support previews (e.g. Zip archive, binary, etc..), it appears with a large card w. preview and an error in preview generation.

Expected:

  • any file type that doesn’t have a preview should default to a small card

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

BEFORE:

Capture d’écran 2026-02-06 à 10 43 11

AFTER:

Screenshot 2026-02-09 at 06 40 09

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.17%. Comparing base (ebfae08) to head (6ed0cba).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20361      +/-   ##
==========================================
- Coverage   45.20%   45.17%   -0.03%     
==========================================
  Files        1633     1633              
  Lines       40230    40234       +4     
  Branches     8321     8324       +3     
==========================================
- Hits        18187    18177      -10     
- Misses      20113    20130      +17     
+ Partials     1930     1927       -3     
Flag Coverage Δ
app_webapp 43.33% <100.00%> (-0.04%) ⬇️
lib_api_client 50.27% <ø> (ø)
lib_core 58.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tMessage/asset/MultipartAssets/MultipartAssets.tsx 97.36% <100.00%> (+0.14%) ⬆️
...ssets/useGetMultipartAsset/useGetMultipartAsset.ts 88.31% <100.00%> (+0.31%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 9
  • Failed: 0
  • Skipped: 4
  • 🔁 Flaky: 1
  • 📊 Total: 14
  • Total Runtime: 87.6s (~ 1 min 28 sec)
specs/CriticalFlow/joinTeam-TC-8635.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ New person joins team and sets up device (tags: TC-8635, crit-flow-web)

@arjita-mitra arjita-mitra enabled auto-merge (squash) February 10, 2026 04:43
@sonarqubecloud
Copy link
Copy Markdown

@arjita-mitra arjita-mitra merged commit 34a1fe9 into dev Feb 10, 2026
52 of 54 checks passed
@arjita-mitra arjita-mitra deleted the bugfix/nonpreview-variant-smallcard/WPB-23340 branch February 10, 2026 05:30
screendriver pushed a commit that referenced this pull request Mar 4, 2026
…0361)

* fix: Use small file cards when no preview is available(WPB-23340)

* test: hasPreview flag to set true/false based on Preview object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants