Skip to content

test: add mention regression tests [WPB-19960]#20498

Merged
markbrockhoff merged 24 commits intodevfrom
mb/mention-tests
Mar 9, 2026
Merged

test: add mention regression tests [WPB-19960]#20498
markbrockhoff merged 24 commits intodevfrom
mb/mention-tests

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Feb 24, 2026

TaskWPB-19960 [Web/QA] Write the Mention regression tests in Playwright

Pull Request

Summary

  • Implement regression tests for mentioning other users in messages
  • Fix aria label of decline button within call cell
  • Group conversation list item locators e.g. for unread or mention status
  • Fix a11y within UserList to correctly label the group admin and member lists
  • Create setup for adding guest users to a group conversation

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Notes for reviewers

  • This PR is on the bigger side, but I made sure all commits inside it are atomic. So instead of looking at everything at once, you may step through the individual commits one after an other during review to reduce the cognitive overhead ;)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.59%. Comparing base (48d14dc) to head (d3deea0).
⚠️ Report is 16 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #20498   +/-   ##
=======================================
  Coverage   45.58%   45.59%           
=======================================
  Files        1641     1641           
  Lines       40496    40496           
  Branches     8354     8352    -2     
=======================================
+ Hits        18461    18463    +2     
  Misses      20097    20097           
+ Partials     1938     1936    -2     
Flag Coverage Δ
app_webapp 43.79% <100.00%> (+<0.01%) ⬆️
lib_api_client 50.17% <ø> (ø)
lib_core 59.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...webapp/src/script/components/UserList/UserList.tsx 71.91% <100.00%> (+0.64%) ⬆️
...ipt/components/calling/CallingCell/CallingCell.tsx 46.49% <ø> (ø)
...ng/CallingCell/CallingControls/CallingControls.tsx 33.33% <ø> (+1.90%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 24, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 225
  • Failed: 0
  • Skipped: 13
  • 🔁 Flaky: 2
  • 📊 Total: 240
  • Total Runtime: 400.6s (~ 6 min 41 sec)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
specs/ParticipantProfile/participantProfile.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Participant Profile > I should not to see Remove from group as a member on participants profile (tags: TC-1488, regression)

@markbrockhoff markbrockhoff force-pushed the mb/mention-tests branch 2 times, most recently from 27eb76f to 6aa7697 Compare March 3, 2026 08:59
@markbrockhoff markbrockhoff force-pushed the mb/mention-tests branch 2 times, most recently from 4a47a4a to 49a706a Compare March 3, 2026 16:48
Comment thread apps/webapp/playwright.config.ts
arjita-mitra
arjita-mitra previously approved these changes Mar 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
10.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@markbrockhoff markbrockhoff disabled auto-merge March 9, 2026 08:26
@markbrockhoff markbrockhoff enabled auto-merge March 9, 2026 08:26
@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 9, 2026
Merged via the queue into dev with commit 2105a28 Mar 9, 2026
58 of 59 checks passed
@markbrockhoff markbrockhoff deleted the mb/mention-tests branch March 9, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants