Skip to content

test: re-enable crit flow group call [WPB-23747]#20519

Merged
markbrockhoff merged 7 commits intodevfrom
mb/test-enterprise-features-workaround
Mar 2, 2026
Merged

test: re-enable crit flow group call [WPB-23747]#20519
markbrockhoff merged 7 commits intodevfrom
mb/test-enterprise-features-workaround

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Feb 27, 2026

TaskWPB-23747 [Web/QA] Fix and re-enable TC-8632 Group call

Pull Request

Summary

This PR re-enables the previously skipped critical flow test for group calling. It was skipped due to a limitation with enterprise features not being unlockable which was resolved. The PR also:

  • Makes the emails of generated users follow their first and last name instead of just last name (for easier debugging)
  • Refactors the critical flow test to follow best practices
  • Removes a lot of no longer needed utils

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.45%. Comparing base (54e2940) to head (636bee4).
⚠️ Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20519      +/-   ##
==========================================
- Coverage   45.45%   45.45%   -0.01%     
==========================================
  Files        1638     1638              
  Lines       40378    40378              
  Branches     8340     8340              
==========================================
- Hits        18354    18353       -1     
  Misses      20089    20089              
- Partials     1935     1936       +1     
Flag Coverage Δ
app_webapp 43.65% <ø> (-0.01%) ⬇️
lib_api_client 50.17% <ø> (ø)
lib_core 59.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markbrockhoff markbrockhoff changed the title test: Re-enable TC-8632 crit flow group call [WPB-23747] test: re-enable TC-8632 crit flow group call [WPB-23747] Feb 27, 2026
@markbrockhoff markbrockhoff changed the title test: re-enable TC-8632 crit flow group call [WPB-23747] test: re-enable crit flow group call [WPB-23747] Feb 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 191
  • Failed: 2
  • Skipped: 13
  • 🔁 Flaky: 5
  • 📊 Total: 211
  • Total Runtime: 330.0s (~ 5 min 30 sec)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/ClearConversationContent/clearConversationContent.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Clear Conversation Content > I want to cancel clearing content of 1:1 conversation via conversation list (tags: TC-155, regression)
specs/Folders/folders.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Folders > I want to move a group conversation to an existing custom folder (tags: TC-548, regression)
specs/ParticipantProfile/participantProfile.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Participant Profile > I want to see Remove from group as an admin seeing a participants profile (tags: TC-1487, regression)
specs/Reactions/reactions.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reactions > Verify liking someone's picture (tags: TC-1528, regression)

@markbrockhoff markbrockhoff force-pushed the mb/test-enterprise-features-workaround branch from 590ec70 to 7346b58 Compare February 27, 2026 10:05
Comment thread apps/webapp/test/e2e_tests/specs/HistoryBackup/historyBackup.spec.ts Outdated
Comment thread apps/webapp/test/e2e_tests/specs/CriticalFlow/groupCalls-TC-8632.spec.ts Outdated
@markbrockhoff markbrockhoff force-pushed the mb/test-enterprise-features-workaround branch from 7346b58 to c30e54e Compare March 2, 2026 08:16
@markbrockhoff markbrockhoff force-pushed the mb/test-enterprise-features-workaround branch from c30e54e to 636bee4 Compare March 2, 2026 09:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 2, 2026

@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 2, 2026
Merged via the queue into dev with commit 88864c7 Mar 2, 2026
51 of 53 checks passed
@markbrockhoff markbrockhoff deleted the mb/test-enterprise-features-workaround branch March 2, 2026 10:13
screendriver pushed a commit that referenced this pull request Mar 4, 2026
* refactor: make sure first and lastname match in email

* test: refactor account management

* test: "fix" group calls critical flow test by adding delay

* refactor: fix assertions in group calls test + remove bad utils

* docs: add jira ticket about 5s delay to comment

* fixup! refactor: make sure first and lastname match in email

* refactor: move feature enablement into createTeam fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants