fix for wait_container_is_ready decorator being depreciated#125
Open
sylphia-nox wants to merge 1 commit intowiremock:masterfrom
Open
fix for wait_container_is_ready decorator being depreciated#125sylphia-nox wants to merge 1 commit intowiremock:masterfrom
sylphia-nox wants to merge 1 commit intowiremock:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the below depreciation warning for @wait_container_is_ready decorator.
...venv\Lib\site-packages\testcontainers\core\waiting_utils.py:215
\python-wiremock.venv\Lib\site-packages\testcontainers\core\waiting_utils.py:215: DeprecationWarning: The @wait_container_is_ready decorator is deprecated and will be removed in a future version. Use structured wait strategies instead: container.waiting_for(HttpWaitStrategy(8080).for_status_code(200)) or container.waiting_for(LogMessageWaitStrategy('ready'))
@wait_container_is_ready()
Please let me know if more information is needed. There does not seem to be a lot of documentation available online right now for this issue.
I did confirm that this PR reduces the warnings when running tests from 7 to 6.
#126
Submitter checklist