➕ add set velocity and set angle velocity gates#3559
Open
Strand8319 wants to merge 5 commits intowiremod:masterfrom
Open
➕ add set velocity and set angle velocity gates#3559Strand8319 wants to merge 5 commits intowiremod:masterfrom
Strand8319 wants to merge 5 commits intowiremod:masterfrom
Conversation
Contributor
|
Needs clamps on the input values. |
Contributor
E2 doesn't do this, maybe it should do it too |
Contributor
Author
You mean make e2 use WireLib clamp? |
Contributor
|
Just mentioning, not related to your PR |
Contributor
Author
Well, I can do it next day |
lua/wire/gates/entity.lua
Outdated
Comment on lines
+1248
to
+1249
| ang = clamp(Vector(ang.p, ang.y, ang.r)) | ||
| phys:SetAngleVelocity(ang) |
Contributor
There was a problem hiding this comment.
You turned the angle into a vector and broke the function
Contributor
|
Oh my bad, actually SetAngularVelocity was taking a vector, change the gate to take VECTOR instead of ANGLE |
This reverts commit c2b86f4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why not?