This repository was archived by the owner on Sep 21, 2022. It is now read-only.
Fix missleading reservationId parameter error#6
Open
tsparber wants to merge 1 commit intowisebed:masterfrom
Open
Fix missleading reservationId parameter error#6tsparber wants to merge 1 commit intowisebed:masterfrom
tsparber wants to merge 1 commit intowisebed:masterfrom
Conversation
The long parameter for the reservation id is defined as --Id but the error messages leads to an non existent --reservationId parameter. Also `executeFlash` function checks the reservation parameter twice (once already in getAssertReservationId)
Author
|
It may also be considered, that the -i shorthand is used twice for the flash command (reservation id and image) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long parameter for the reservation id is defined as --Id but the error messages leads to an non existent --reservationId parameter.
Also
executeFlashfunction checks the reservation parameter twice (once already in getAssertReservationId)