Conversation
WalkthroughReorganizes many settings pages into discrete Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@DedeHai I like the new look :-) |
|
correct. |
|
I updated all config pages and made some other minor modifications, mainly:
Total additional flash use: ~150bytes |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@wled00/data/settings_sec.htm`:
- Around line 62-70: The HTML has invalid nesting because the inline element
<span id="OTA"> opens before a </div> and closes after several block elements;
move or refactor this so the element with id "OTA" does not span across
block-level boundaries — either wrap the relevant block content inside a single
container (e.g., give the <div class="sec"> or a new <div> the id "OTA" instead
of using a span) or remove the span and toggle visibility via the existing <div
class="sec"> using the same id; ensure related JS (function U(), and inputs
named "AO" and "SU") references are updated to target the new container.
after LED settings now come color & white settings, then additional hardware, then general settings. Also updated some wordings to avoid FAQ.









I am proposing "sections" instead of a "continuous list"

like this:
had to increase the contrast slightly to make it work well, i.e. dim the background down.
let me know what you think and I will update all config pages to this pattern.
the flash cost is minimal, changes to LED settings page is a handful of bytes (64 if you need a number ;) )
Summary by CodeRabbit
Style
Refactor
New Features
Other