Skip to content

Fixes issue in Dissolve when a palette has same color pixel as the current background color when Complete is enabled #5453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobLoeffler68 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Fixes issue in Dissolve when a palette has same color pixel as the current background color when Complete is enabled #5453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6516c60
Fixes issue in Dissolve when a palette has same color pixel as the cu…
BobLoeffler68 Mar 26, 2026
8dcd2d7
Made the fix for only when Complete is enabled.
BobLoeffler68 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion wled00/FX.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,7 @@ static const char _data_FX_MODE_TWINKLE[] PROGMEM = "Twinkle@!,!;!,!;!;;m12=0";
* Dissolve function
*/
void dissolve(uint32_t color) {
if (SEGLEN < 1) FX_FALLBACK_STATIC;
unsigned dataSize = sizeof(uint32_t) * SEGLEN;
if (!SEGENV.allocateData(dataSize)) FX_FALLBACK_STATIC; //allocation failed
uint32_t* pixels = reinterpret_cast<uint32_t*>(SEGENV.data);
Expand All @@ -702,7 +703,9 @@ void dissolve(uint32_t color) {
unsigned i = hw_random16(SEGLEN);
if (SEGENV.aux0) { //dissolve to primary/palette
if (pixels[i] == SEGCOLOR(1)) {
pixels[i] = color == SEGCOLOR(0) ? SEGMENT.color_from_palette(i, true, PALETTE_SOLID_WRAP, 0) : color;
uint32_t c = color == SEGCOLOR(0) ? SEGMENT.color_from_palette(i, true, PALETTE_SOLID_WRAP, 0) : color;
if (SEGMENT.check2 && c == SEGCOLOR(1)) c ^= 0x00000001; // change the color slightly so the effect doesn't get stuck in Complete mode if color is same as bkg color
pixels[i] = c;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
break; //only spawn 1 new pixel per frame
}
} else { //dissolve to secondary
Expand Down
Loading