Conversation
exowanderer
left a comment
There was a problem hiding this comment.
Hello @philippesaade-wmde
I did my best to review the files. I still have about half to complete. Please feel free to add responses / comments on the 43 comments I left so far.
exowanderer
left a comment
There was a problem hiding this comment.
I was able to add a few more comments, mostly about if new functionality could break downstream (user) behaviour
exowanderer
left a comment
There was a problem hiding this comment.
I requested several descriptions per file in the "search" subdir
exowanderer
left a comment
There was a problem hiding this comment.
Added a few more requests for infomation
wikidatasearch/services/datastax.py
Outdated
There was a problem hiding this comment.
Will this break any downstream functionality for community contributors or WDEmbedding reusers?
wikidatasearch/services/search.py
Outdated
There was a problem hiding this comment.
Is this the original file that is now called HybridSearch.py?
There was a problem hiding this comment.
Alright, I gave a few comments about accessibility and behavior, the client seems to look alright when I run it locally, but I'd recommend to still click around some more with the back-end on to see if there are any odd behaviors I missed (I only ran the vue dev server).
All in all it looks great, some nice improvements and clear user instructions.
Co-authored-by: Itamar Givon <dev@itamargivon.com>
Co-authored-by: Itamar Givon <dev@itamargivon.com>
Co-authored-by: Itamar Givon <dev@itamargivon.com>
b25b01a to
1962ee8
Compare
…t behavior. Minor bug fix in VectorSearch for selecting the correct collection with the similarity score route
itamargiv
left a comment
There was a problem hiding this comment.
Looks good on my part, thank you!
The vector database architecture will be migrated to a sharded design based on language and entity type. Instead of a single database containing all vectors, the system will use a separate vector database per language per entity type.
Changes include: