ML-DSA: Support deterministic signing#88
Open
mjdemilliano wants to merge 2 commits intowolfSSL:masterfrom
Open
ML-DSA: Support deterministic signing#88mjdemilliano wants to merge 2 commits intowolfSSL:masterfrom
mjdemilliano wants to merge 2 commits intowolfSSL:masterfrom
Conversation
Member
|
@mjdemilliano is an approved contrinutor |
There was a problem hiding this comment.
Pull request overview
Adds deterministic ML-DSA signature generation support by allowing callers to supply an explicit 32-byte seed, wiring the new wolfSSL APIs through the Python binding and adding test coverage for deterministic behavior.
Changes:
- Add
MlDsaPrivate.sign_with_seed()to generate deterministic signatures using a caller-provided seed (optionally with a context). - Extend the CFFI
cdefwithwc_dilithium_sign_msg_with_seed/wc_dilithium_sign_ctx_msg_with_seed. - Add a unit test validating deterministic re-signing and basic seed-length checking.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| wolfcrypt/ciphers.py | Introduces deterministic signing API and seed-length constant for ML-DSA private keys. |
| tests/test_mldsa.py | Adds tests for deterministic signing behavior with a fixed seed. |
| scripts/build_ffi.py | Exposes the new wolfSSL deterministic-signing functions to CFFI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielinux
previously requested changes
Apr 8, 2026
Member
danielinux
left a comment
danielinux
left a comment
There was a problem hiding this comment.
Please address copilot's commends
- Use constant from ciphers.py - Raise ValueError or TypeError in sign_with_seed instead of assert - Add missing test case
Contributor
Author
|
Resolved comments |
dgarske
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.