Redirect private task OAuth failures to dashboard#1456
Open
esorense wants to merge 2 commits intoworknenjoy:masterfrom
Open
Redirect private task OAuth failures to dashboard#1456esorense wants to merge 2 commits intoworknenjoy:masterfrom
esorense wants to merge 2 commits intoworknenjoy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the private task OAuth error flow by redirecting invalid GitHub callback failures back to the dashboard instead of returning a raw
401response.Changes
/#/profile?createTaskError=trueWhy
The success path already redirects the user back to the product, and part of the failure path was previously aligned with that behavior. This change covers the remaining failure branches so users do not get stuck on an API error response page.