chore: split tsconfig into app/test project references#391
Merged
Conversation
TS language server couldn't resolve Vitest globals (vi, describe, expect, Mock) in spec files because tsconfig.json excluded them. Split into solution-style project references so the editor resolves types correctly while keeping test types isolated from production code.
Replace the global type declaration in vitest.setup.ts with explicit imports in each spec file that uses Mock or MockInstance.
gjtorikian
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsconfig.jsoninto solution-style project references (tsconfig.app.json+tsconfig.test.json) so the TS language server resolves Vitest globals (vi,describe,expect,Mock,MockInstance) in spec filesas React.CSSPropertiesassertions for CSS custom properties inimpersonation.tsx(pre-existing type error surfaced by the new config)typecheckscript now validates both app and test configsNo runtime behavior changes.
Test plan
pnpm run buildpassespnpm typecheckpasses (now checks both app and test files)pnpm testpasses (302 tests)pnpm run lintpasses.spec.ts/.spec.tsxfiles