Open
Conversation
Bumps [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router) from 7.10.1 to 7.12.0. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router@7.12.0/packages/react-router) --- updated-dependencies: - dependency-name: react-router dependency-version: 7.12.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR bumps react-router from 7.10.1 to 7.12.0, a minor version update that includes security enhancements and bug fixes.
Major Changes in React Router 7.12.0:
- CSRF Protection Enhancement: React Router now rejects form submissions to UI routes from external origins by default. This is a security improvement but may affect applications if they receive form submissions from different origins.
- Bug fixes for
generatePathwith suffixed params, HTML escaping in scroll restoration, and redirect location validation - New unstable features for trailing slash handling and subresource integrity
Impact on authkit-react-router:
- This library primarily uses loaders (GET requests) which are not affected by the new CSRF protection
- The README documents action handlers (POST) for sign-out functionality that users implement in their apps
- Users of this library may be affected if they have action handlers that receive requests from external origins
- No breaking changes to the library's API or functionality
What Users Should Know:
If users of this library have action handlers that need to accept form submissions from external origins, they will need to configure allowedActionOrigins in their react-router.config.ts file. The default behavior (blocking external origins) is a security best practice and should be maintained unless explicitly required.
Confidence Score: 4/5
- This PR is safe to merge with minimal risk - it's a standard dependency update with beneficial security improvements
- This is a routine dependency update (minor version bump) that adds security improvements and bug fixes. The new CSRF protection in React Router 7.12.0 is a positive security enhancement that doesn't break this library's functionality. The library primarily uses loaders (not affected by CSRF changes), and any action handlers are implemented by users in their apps. Score of 4 (not 5) because users may need to be aware of the new CSRF behavior if they implement action handlers that accept external origins, though this is uncommon and the default blocking behavior is the secure choice.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| package-lock.json | 4/5 | React Router dependency bumped from 7.10.1 to 7.12.0, includes new CSRF protection and bug fixes |
Sequence Diagram
sequenceDiagram
participant User
participant App as User's App
participant Library as authkit-react-router
participant RR as React Router 7.12.0
participant WorkOS
Note over RR: New CSRF Protection Active
User->>App: Submit Form (POST)
App->>RR: action() handler receives request
RR->>RR: Check Origin header
alt Origin matches app domain
RR->>Library: Pass request to action
Library->>WorkOS: API call (signOut, etc)
WorkOS-->>Library: Response
Library-->>RR: Redirect response
RR-->>App: Handle redirect
App-->>User: Success
else Origin is external
RR-->>App: Reject (403 Forbidden)
App-->>User: CSRF Error
end
Note over RR: Configure allowedActionOrigins<br/>in react-router.config.ts if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-router from 7.10.1 to 7.12.0.
Release notes
Sourced from react-router's releases.
Changelog
Sourced from react-router's changelog.
... (truncated)
Commits
26653a6chore: Update version for release (#14712)7ac2346chore: Update version for release (pre) (#14709)75b1ef5Add origin checks for UI route submissions (#14708)c05ef93Validate redirect locations (#14706)c89c32cEscape HTML in scroll restoration keys (#14705)cbcbf30fix: pass nonce to importmap script when using subResourceIntegrity (#14675)30f6c1dfix(react-router): handle parameters with static suffixes in generatePath (#1...7f140e0Handle data requests with trailing slash consistently (#14644)1954af6Preserve hydrate property on client loaders during instrumentation (#14674)5ce5cd4chore: formatDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.