Open
Conversation
The support library has been replaced by androidx. https://developer.android.com/jetpack/androidx/migrate I know turning on `android.useAndroidX` and `android.enableJetifier` should automatically convert third party librarys to use android x, but for this repo it wasn't the case. It gaves the error: ``` /node_modules/react-native-image-tools-wm/android/src/main/java/net/wowmaking/Utility.java:9: error: package android.support.media does not exist import android.support.media.ExifInterface; ^ ``` Given that whole android ecosystem & community has already adopted to use androidx, it's time to use android x flag correctly in all libraries as well. So I'm pulling this code change.
|
+1, I need that 👆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The support library has been replaced by androidx.
https://developer.android.com/jetpack/androidx/migrate
I know turning on
android.useAndroidXandandroid.enableJetifiershould automatically convert third party librarys to use android x, but for this repo it wasn't the case.It gaves the error:
Given that whole android ecosystem & community has already adopted to use androidx, it's time to use android x flag correctly in all libraries as well. So I'm pulling this code change.