Conversation
…ltiple translations inside an array
…e translations and improve node handling logic
Collaborator
Author
|
@johnhooks what do you think about? It's a lot of code, but in some cases (e.g., in PHP [__(“a”),__(‘b’),__(“c”)] it's necessary (or at least it's the only way I've found). |
Contributor
|
@erikyo your solution looks correct to me. The fix doesn't assume the structure of the call expression arguments.
|
Collaborator
Author
|
@johnhooks Thank you! I was a bit unsure because I didn't want to burden doTree fixing edge cases... As usual, you are very kind and thorough. 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor argument handling for translation functions, should allow multiple translations inside an array