Add support for application passwords via env vars and wp-cli.yml config#151
Open
Add support for application passwords via env vars and wp-cli.yml config#151
Conversation
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for application passwords in REST API
Add support for application passwords via env vars and wp-cli.yml config
Mar 19, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
… tests Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress 5.6+ application passwords could only be supplied by embedding credentials in the
--httpURL, exposing secrets in shell history and process listings.Changes
inc/Runner.php: Extracts credential resolution into a newRunner::resolve_auth()public static helper and supports three sources with explicit priority ordering:--http=admin:pass@example.com(existing, unchanged)WP_REST_CLI_AUTH_USER/WP_REST_CLI_AUTH_PASSWORDenvironment variableshttp_user/http_passwordkeys inwp-cli.ymlBug fix: URL-embedded credentials now work correctly even when
--httphas no scheme (e.g.--http=admin:pass@example.com). The URL is normalised beforeparse_url(), consistent with the existingauto_discover_api()behaviour.tests/Runner_Resolve_Auth_Test.php: New PHPUnit test file with 10 tests covering all priority cases and edge cases (config-only, env overrides config, URL overrides env, URL without scheme, empty env username skipped, password-less variants).Usage
Environment variables (CI/CD, avoids secrets in config):
WP_REST_CLI_AUTH_USER=admin \ WP_REST_CLI_AUTH_PASSWORD="X9yS 9YYn pbaU 5H8A kJNO DEfe" \ wp --http=https://example.com rest post create --title=wibblewp-cli.yml(persistent per-project defaults):Application passwords with spaces work cleanly with both approaches without requiring URL encoding.
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.