Pass lists through verbatim, matching stdlib behavior#6
Closed
klardotsh wants to merge 2 commits intoxando:masterfrom
Closed
Pass lists through verbatim, matching stdlib behavior#6klardotsh wants to merge 2 commits intoxando:masterfrom
klardotsh wants to merge 2 commits intoxando:masterfrom
Conversation
Resolves xando#5 by passing pre-existing lists through verbatim - a case where this can be triggered is passing "remainder" argument lists from an `ArgumentParser` through to `subprocess.run`.
Author
|
Closing to re-open off a branch that actually includes tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually also includes #4 because I forked from @brbsix's fork - can rebase if you'd like.
This resolves #5, though I can't prove it on Python 3 (which is really where one can prove behavior is 1:1 with stdlib, since this was added in 3.3) due to other issues relating to how
stdoutis parsed. Proven resolved on Python 2.7.