capture_output is not on by default in the standard library - replicate this behavior#9
Closed
klardotsh wants to merge 2 commits intoxando:masterfrom
Closed
Conversation
Author
|
Will fix tests some day that's not today - interesting that this suddenly fails when the result I'm seeing on screen is what one would expect. |
Author
|
Closing this to clear out my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be seen even in a repl - stdlib
subprocess.run('clang')will pass through the error about no input files, this library will swallow it because it sets stderr/stdout tosubprocess.PIPEby default. This PR fixes that.Same drill as my other two PRs, not 100% clean. Includes #4. Can rebase.