Tweak strategies so we don't reject so many examples.#496
Open
Tweak strategies so we don't reject so many examples.#496
Conversation
Collaborator
dcherian
commented
Feb 26, 2026
dcherian
commented
``` ┌─────────────────────────────────────┬────────┬────────┐ │ Metric │ Before │ After │ ├─────────────────────────────────────┼────────┼────────┤ │ array.dtype.kind='f' │ 1.10% │ 8.49% │ ├─────────────────────────────────────┼────────┼────────┤ │ array.dtype.kind='i' │ 3.02% │ 5.26% │ ├─────────────────────────────────────┼────────┼────────┤ │ array.dtype.kind='u' │ 2.06% │ 10.36% │ ├─────────────────────────────────────┼────────┼────────┤ │ Invalid (line 101, not_overflowing) │ 27.57% │ 21.73% │ ├─────────────────────────────────────┼────────┼────────┤ │ Total invalid examples │ 429 │ 289 │ ├─────────────────────────────────────┼────────┼────────┤ │ all-NaN groups │ 1.10% │ 7.64% │ └─────────────────────────────────────┴────────┴────────┘ ```
- Add float32-aware tolerance (rtol=1e-5) in test_groupby_reduce_numpy_vs_other since chunked vs unchunked var/std on float32 with large values legitimately differs beyond the default rtol=1e-7. - Relax test_scans_against_numpy tolerance from rtol=1e-13 to rtol=1e-12 to handle cumsum accumulation order differences with large float64 values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.