Skip to content

tests: remove Big Endian–specific compressed size assertion #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasiribmcon wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

tests: remove Big Endian–specific compressed size assertion #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/test/java/org/xerial/snappy/SnappyOutputStreamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ public void batchingOfWritesShouldNotAffectCompressedDataSize()
byte[] expectedCompressedData = compressAsChunks(orig, Integer.MAX_VALUE);
// Hardcoding an expected compressed size here will catch regressions that lower the
// compression quality:
if (ByteOrder.nativeOrder() == ByteOrder.BIG_ENDIAN)
assertEquals(90992, expectedCompressedData.length);
else if(OSInfo.getArchName() == "aarch64")
if(OSInfo.getArchName() == "aarch64")
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Java, you should use the .equals() method for string comparison instead of ==. The == operator checks for reference equality (whether they are the same object), not value equality (whether they have the same character sequence). While this might work in some cases due to string interning, it's not a reliable practice and can lead to unexpected behavior. Using .equals() is safer and more explicit.

Suggested change
if(OSInfo.getArchName() == "aarch64")
if("aarch64".equals(OSInfo.getArchName()))

// Arm has a better compression ratio
assertEquals(91051, expectedCompressedData.length);
else
Expand Down
Loading