✨ Quality: Fix serialization of native functions like Number, String#214
Open
hieuit095 wants to merge 1 commit intoyahoo:mainfrom
Open
Conversation
The issue is that serialize-javascript throws a TypeError when trying to serialize native functions (like `Number`, `String`, `Array`, etc.). The fix should detect native built-in constructors and serialize them by their name (e.g., `Number` instead of throwing an error). Affected files: index.js Signed-off-by: hieuit095 <139037144+hieuit095@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The issue is that serialize-javascript throws a TypeError when trying to serialize native functions (like
Number,String,Array, etc.). The fix should detect native built-in constructors and serialize them by their name (e.g.,Numberinstead of throwing an error).Severity:
mediumFile:
index.jsSolution
The issue is that serialize-javascript throws a TypeError when trying to serialize native functions (like
Number,String,Array, etc.). The fix should detect native built-in constructors and serialize them by their name (e.g.,Numberinstead of throwing an error).Changes
index.js(modified)Testing
Closes #179