Lkind check allows for irreducible exciton calculation#224
Open
palful wants to merge 2 commits intoyambo-code:5.4from
Open
Lkind check allows for irreducible exciton calculation#224palful wants to merge 2 commits intoyambo-code:5.4from
palful wants to merge 2 commits intoyambo-code:5.4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with Alberto, currently a check at line 166 of
K_driver_initwould not acceptLkind='tilde'as input option for irreducible exciton calculations, although this case is coded below at line 266 of the same file and also documented at input generation viaINIT_load.The change simply recognizes
Lkind='tilde'as an option to switch off the exchange part of the BSE kernel.Also note that
is equivalent - but more straightforward - to