Add nil checks for #462 and #459#463
Open
chrisballinger wants to merge 6 commits intoyapstudios:masterfrom
Open
Add nil checks for #462 and #459#463chrisballinger wants to merge 6 commits intoyapstudios:masterfrom
chrisballinger wants to merge 6 commits intoyapstudios:masterfrom
Conversation
Contributor
Author
|
I can preliminarily verify that this patch resolves the crashes I was seeing from end users. |
michaelkirk-signal
left a comment
michaelkirk-signal
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| collectionKey.collection, collectionKey.key, object, | ||
| another.collection, another.key, anotherObject); | ||
|
|
||
| if (object && anotherObject) { |
There was a problem hiding this comment.
Indentation seems off in all these changes.
| NSString *pageKey = pageMetadata->pageKey; | ||
| YapDatabaseViewPage *page = [self pageForPageKey:pageKey]; | ||
|
|
||
| NSAssert(page != nil, @"Missing page in group(%@)", group); |
There was a problem hiding this comment.
Any idea what can lead to this?
FWIW we've seen similar crashes, but haven't root-caused it.
Hopefully this assert/logging will help track it down...
Contributor
Author
There was a problem hiding this comment.
Not sure, I've never caught it live, only from crash logs
|
I'll add my thanks as well. We've been beating our heads against this with no root cause either. |
small3flower
added a commit
to difftim/YapDatabase
that referenced
this pull request
Sep 7, 2022
small3flower
added a commit
to difftim/YapDatabase
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really sure if some of these fixes are logically correct, but I'm pretty sure they will resolve the crashes #462 and #459.