Fix range options forgetting its initial fixed range if group is smaller#490
Open
joelekstrom wants to merge 1 commit intoyapstudios:masterfrom
Open
Fix range options forgetting its initial fixed range if group is smaller#490joelekstrom wants to merge 1 commit intoyapstudios:masterfrom
joelekstrom wants to merge 1 commit intoyapstudios:masterfrom
Conversation
be31b7a to
c498d76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When I for example I want to display a maximum of two items in a specific group and do this:
there will be a bug if the group contains < N items when this call is made. Internally, YapDatabase sets the length of the range options to MIN(length, objectCount), and then forgets about this value.
This is a problem when the view and mappings are created first, and then data comes in from a network request to populate the groups. The range options will forever be 0 in length.
If this was intended, I'd love to understand why!
Solution
Never overwrite the
maxLengthof fixed range options