Remove NoneType in results preprocessing#18
Open
awilliamson wants to merge 1 commit intoyhyu13:masterfrom
Open
Remove NoneType in results preprocessing#18awilliamson wants to merge 1 commit intoyhyu13:masterfrom
awilliamson wants to merge 1 commit intoyhyu13:masterfrom
Conversation
Author
|
Don't merge yet. This has knock on effects when training due to how chunking is done. As expected shape is 100000. |
|
When I remove NoneType in results preprocessing, I have another error that the training trunk shape is not 100000. How to resolve this error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None types in results for preprocessing will result in an error when trying to return. Filtering out the None types beforehand appears to fix this, and preprocessing - alongside #17 - continues to actually write now.