Skip to content

Fix #234: Remove attribute sorting#236

Merged
vjik merged 15 commits intoyiisoft:masterfrom
FrankiFixx:fix-234-issue
Mar 14, 2026
Merged

Fix #234: Remove attribute sorting#236
vjik merged 15 commits intoyiisoft:masterfrom
FrankiFixx:fix-234-issue

Conversation

@FrankiFixx
Copy link
Contributor

@FrankiFixx FrankiFixx commented Jan 14, 2025

Q A
Is bugfix?
New feature?
Breaks BC?
Fixes #234

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (645f562) to head (e569969).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #236   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       830       827    -3     
===========================================
  Files             89        89           
  Lines           2231      2225    -6     
===========================================
- Hits            2231      2225    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@samdark samdark requested a review from vjik January 15, 2025 18:03
@vjik vjik changed the title Fix 234 issue Fix #234: Remove attribute sorting Jan 16, 2025
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

We'll merge it after other BC-break changes are added.

@vjik vjik added the status:ready for merge The pull request is OK to be merged. label Jan 16, 2025
@vjik vjik added this to the 4.0 milestone Mar 8, 2025
@vjik vjik added the severity:BC breaking Breaks backwards compatibility label Jan 5, 2026
@vjik vjik mentioned this pull request Jan 5, 2026
@samdark samdark changed the base branch from master to 4.0.0 March 13, 2026 13:04
@vjik vjik deleted the branch yiisoft:master March 13, 2026 14:18
@vjik vjik closed this Mar 13, 2026
@samdark samdark reopened this Mar 13, 2026
@samdark samdark changed the base branch from 4.0.0 to master March 13, 2026 20:25
vjik added 3 commits March 14, 2026 08:33
…-234-issue

# Conflicts:
#	tests/HtmlTest.php
#	tests/Tag/Base/BooleanInputTagTest.php
#	tests/Tag/Base/TagTest.php
#	tests/Tag/FormTest.php
#	tests/Tag/Input/CheckboxTest.php
#	tests/Tag/Input/ColorTest.php
#	tests/Tag/Input/FileTest.php
#	tests/Tag/Input/RadioTest.php
#	tests/Tag/LinkTest.php
#	tests/Tag/SourceTest.php
#	tests/Tag/TrackTest.php
#	tests/Widget/CheckboxListTest.php
#	tests/Widget/RadioListTest.php
@vjik vjik merged commit e51c869 into yiisoft:master Mar 14, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

severity:BC breaking Breaks backwards compatibility status:ready for merge The pull request is OK to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants