Use new %TagClass%() instead of %TagClass%::tag() by razvbir · Pull Request #264 · yiisoft/html

razvbir · 2026-03-04T20:49:37Z

Q	A
Is bugfix?	❌
New feature?	✔️
Breaks BC?	❌
Fixed issues	#243

This reverts commit 8149d93.

This is drops support for php 8.1, 8.2, 8.3

codecov · 2026-03-04T20:56:57Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b89e5c) to head (702ed52).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##              master      #264   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       829       829           
===========================================
  Files             89        89           
  Lines           2229      2229           
===========================================
  Hits            2229      2229

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CHANGELOG.md

This add tests that check that the static constructor has the Deprecated attribute

Copilot

Pull request overview

Updates the library to prefer direct instantiation (new ...) over static “constructors” like ::tag() / ::create() / CustomTag::name(), aligning with the PHP 8.4 deprecation attribute and the direction described in issue #243.

Changes:

Made constructors public for NormalTag, VoidTag, CustomTag, and key widgets; marked static constructors (tag(), create(), name()) as deprecated via #[Deprecated].
Replaced internal usages and test suites to instantiate via new ... instead of static constructors.
Updated documentation and CI matrices to focus on PHP 8.4+.

Reviewed changes

Copilot reviewed 109 out of 109 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Widget/RadioListTest.php	Switches to `new RadioList(...)`; adds deprecation reflection test.
tests/Widget/CheckboxListTest.php	Switches to `new CheckboxList(...)`; adds deprecation reflection test.
tests/Widget/ButtonGroupTest.php	Switches to `new ButtonGroup()`; adds deprecation reflection test.
tests/Tag/VideoTest.php	Replaces `::tag()` usage with `new ...` for media tags.
tests/Tag/UlTest.php	Replaces list tag construction with `new ...`.
tests/Tag/TrackTest.php	Replaces `Track::tag()` with `new Track()`.
tests/Tag/TrTest.php	Replaces `Tr::tag()` and cell tags with `new ...`.
tests/Tag/TitleTest.php	Replaces `Title::tag()` with `new Title()`.
tests/Tag/TheadTest.php	Replaces `Thead::tag()` / `Tr::tag()` with `new ...`.
tests/Tag/ThTest.php	Replaces `Th::tag()` with `new Th()`.
tests/Tag/TfootTest.php	Replaces `Tfoot::tag()` / `Tr::tag()` with `new ...`.
tests/Tag/TextareaTest.php	Replaces `Textarea::tag()` with `new Textarea()`.
tests/Tag/TdTest.php	Replaces `Td::tag()` with `new Td()`.
tests/Tag/TbodyTest.php	Replaces `Tbody::tag()` / `Tr::tag()` with `new ...`.
tests/Tag/TableTest.php	Replaces `Table::tag()` and related tag factories with `new ...`.
tests/Tag/StyleTest.php	Replaces `Style::tag()` with `new Style()`.
tests/Tag/StrongTest.php	Replaces `Strong::tag()` with `new Strong()`.
tests/Tag/SpanTest.php	Replaces `Span::tag()` with `new Span()`.
tests/Tag/SourceTest.php	Replaces `Source::tag()` with `new Source()`.
tests/Tag/SmallTest.php	Replaces `Small::tag()` with `new Small()`.
tests/Tag/SelectTest.php	Replaces `Select::tag()` / `Option::tag()` / `Optgroup::tag()` with `new ...`.
tests/Tag/SectionTest.php	Replaces `Section::tag()` and nested tags with `new ...`.
tests/Tag/ScriptTest.php	Replaces `Script::tag()` and nested `Noscript`/`Div` with `new ...`.
tests/Tag/PreTest.php	Replaces `Pre::tag()` with `new Pre()`.
tests/Tag/PictureTest.php	Replaces `Picture::tag()` / `Img::tag()` / `Source::tag()` with `new ...`.
tests/Tag/PTest.php	Replaces `P::tag()` with `new P()`.
tests/Tag/OptionTest.php	Replaces `Option::tag()` with `new Option()`.
tests/Tag/OptgroupTest.php	Replaces `Optgroup::tag()` / `Option::tag()` with `new ...`.
tests/Tag/OlTest.php	Replaces ordered list construction with `new ...`.
tests/Tag/NoscriptTest.php	Replaces `Noscript::tag()` / `Img::tag()` with `new ...`.
tests/Tag/NavTest.php	Replaces `Nav::tag()` and nested tags with `new ...`.
tests/Tag/MetaTest.php	Replaces `Meta::tag()` with `new Meta()`.
tests/Tag/LinkTest.php	Replaces `Link::tag()` with `new Link()`.
tests/Tag/LiTest.php	Replaces `Li::tag()` with `new Li()`.
tests/Tag/LegendTest.php	Replaces `Legend::tag()` with `new Legend()`.
tests/Tag/LabelTest.php	Replaces `Label::tag()` with `new Label()`.
tests/Tag/InputTest.php	Replaces `Input::tag()` with `new Input()`.
tests/Tag/Input/RangeTest.php	Replaces `Range::tag()` with `new Range()`.
tests/Tag/Input/RadioTest.php	Replaces `Radio::tag()` with `new Radio()`.
tests/Tag/Input/FileTest.php	Replaces `File::tag()` with `new File()`.
tests/Tag/Input/ColorTest.php	Replaces `Color::tag()` with `new Color()`.
tests/Tag/Input/CheckboxTest.php	Replaces `Checkbox::tag()` with `new Checkbox()`.
tests/Tag/ImgTest.php	Replaces `Img::tag()` with `new Img()`.
tests/Tag/ITest.php	Replaces `I::tag()` with `new I()`.
tests/Tag/HtmlTest.php	Replaces `Html::tag()` (tag class) with `new Html()`.
tests/Tag/HrTest.php	Replaces `Hr::tag()` with `new Hr()`.
tests/Tag/HgroupTest.php	Replaces `Hgroup::tag()` and nested heading tags with `new ...`.
tests/Tag/HeaderTest.php	Replaces `Header::tag()` and nested tags with `new ...`.
tests/Tag/H6Test.php	Replaces `H6::tag()` with `new H6()`.
tests/Tag/H5Test.php	Replaces `H5::tag()` with `new H5()`.
tests/Tag/H4Test.php	Replaces `H4::tag()` with `new H4()`.
tests/Tag/H3Test.php	Replaces `H3::tag()` with `new H3()`.
tests/Tag/H2Test.php	Replaces `H2::tag()` with `new H2()`.
tests/Tag/H1Test.php	Replaces `H1::tag()` with `new H1()`.
tests/Tag/FormTest.php	Replaces `Form::tag()` with `new Form()`.
tests/Tag/FooterTest.php	Replaces `Footer::tag()` and nested tags with `new ...`.
tests/Tag/FieldsetTest.php	Replaces `Fieldset::tag()` / `Legend::tag()` with `new ...`.
tests/Tag/EmTest.php	Replaces `Em::tag()` with `new Em()`.
tests/Tag/DivTest.php	Replaces `Div::tag()` with `new Div()`.
tests/Tag/DatalistTest.php	Replaces `Datalist::tag()` / `Option::tag()` with `new ...`.
tests/Tag/CustomTagTest.php	Replaces `CustomTag::name()` with `new CustomTag(...)`; adds deprecation reflection test.
tests/Tag/ColgroupTest.php	Replaces `Colgroup::tag()` / `Col::tag()` with `new ...`.
tests/Tag/ColTest.php	Replaces `Col::tag()` with `new Col()`.
tests/Tag/CodeTest.php	Replaces `Code::tag()` with `new Code()`.
tests/Tag/CaptionTest.php	Replaces `Caption::tag()` / `CustomTag::name()` with `new ...`.
tests/Tag/ButtonTest.php	Replaces `Button::tag()` with `new Button()`.
tests/Tag/BrTest.php	Replaces `Br::tag()` with `new Br()`.
tests/Tag/BodyTest.php	Replaces `Body::tag()` with `new Body()`.
tests/Tag/Base/VoidTagTest.php	Uses `new TestVoidTag()`; adds deprecation reflection test for `VoidTag::tag()`.
tests/Tag/Base/TagTest.php	Updates base tag tests to use `new TestTag()` instead of `TestTag::tag()`.
tests/Tag/Base/TagSourcesTraitTest.php	Updates trait tests to use `new ...` for sources.
tests/Tag/Base/TagContentTraitTest.php	Updates trait tests to use `new ...` for content tags.
tests/Tag/Base/TableRowsContainerTagTest.php	Updates container tag tests to use `new ...` for rows/cells.
tests/Tag/Base/TableCellTagTest.php	Updates cell tag tests to use `new TestTableCellTag()`.
tests/Tag/Base/NormalTagTest.php	Uses `new TestNormalTag()`; adds deprecation reflection test for `NormalTag::tag()`.
tests/Tag/Base/MediaTagTest.php	Updates media tag tests to use `new ...` for sources/tracks.
tests/Tag/Base/ListTagTest.php	Updates list tag tests to use `new ...` for items.
tests/Tag/Base/InputTagTest.php	Updates input tag tests to use `new TestInputTag()`.
tests/Tag/Base/BooleanInputTagTest.php	Updates boolean input tag tests to use `new ...`.
tests/Tag/BTest.php	Replaces `B::tag()` with `new B()`.
tests/Tag/AudioTest.php	Replaces `Audio::tag()` and nested tags with `new ...`.
tests/Tag/AsideTest.php	Replaces `Aside::tag()` and nested tags with `new ...`.
tests/Tag/ArticleTest.php	Replaces `Article::tag()` and nested tags with `new ...`.
tests/Tag/AddressTest.php	Replaces `Address::tag()` and nested `A` with `new ...`.
tests/Tag/ATest.php	Replaces `A::tag()` with `new A()`.
tests/HtmlTest.php	Updates `Html::noscript()` test to pass `new Div()` instead of `Div::tag()`.
src/Widget/RadioList/RadioList.php	Makes constructor public; deprecates `RadioList::create()`.
src/Widget/CheckboxList/CheckboxList.php	Makes constructor public; deprecates `CheckboxList::create()`.
src/Widget/ButtonGroup.php	Makes constructor public; deprecates `ButtonGroup::create()`.
src/Tag/Tr.php	Replaces internal `Td::tag()` / `Th::tag()` creation with `new ...`.
src/Tag/Table.php	Replaces `Caption::tag()` with `new Caption()` in helper.
src/Tag/Select.php	Replaces `Optgroup::tag()` / `Option::tag()` with `new ...`.
src/Tag/Script.php	Replaces `Noscript::tag()` with `new Noscript()`.
src/Tag/Optgroup.php	Replaces `Option::tag()` with `new Option()`.
src/Tag/Meta.php	Replaces `self::tag()` with `new self()` in static factories.
src/Tag/Link.php	Replaces `self::tag()` with `new self()` in static factory.
src/Tag/Input/Range.php	Replaces `CustomTag::name(...)` with `new CustomTag(...)`.
src/Tag/Input.php	Replaces `::tag()` usage in static factories with `new ...`.
src/Tag/CustomTag.php	Makes constructor public; deprecates `CustomTag::name()`.
src/Tag/Button.php	Replaces `self::tag()` with `new self()` in factories.
src/Tag/Base/VoidTag.php	Makes constructor public; deprecates `VoidTag::tag()`.
src/Tag/Base/NormalTag.php	Makes constructor public; deprecates `NormalTag::tag()`.
src/Tag/Base/ListTag.php	Replaces `Li::tag()` with `new Li()` when building items.
src/Html.php	Updates helpers to instantiate tag objects with `new ...` (and widgets with constructors).
README.md	Updates examples to use `new ...` instead of static constructors.
CHANGELOG.md	Adds an entry for the change (currently with a placeholder version header).
.github/workflows/static.yml	Reduces PHP matrix to 8.4 only.
.github/workflows/composer-require-checker.yml	Reduces PHP matrix to 8.4–8.5.
.github/workflows/build.yml	Reduces PHP matrix to 8.4–8.5.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Tag/Base/NormalTag.php

CHANGELOG.md

.github/workflows/build.yml

src/Widget/CheckboxList/CheckboxList.php

src/Tag/Base/NormalTag.php

src/Tag/Base/VoidTag.php

.github/workflows/build.yml

src/Tag/CustomTag.php

src/Widget/RadioList/RadioList.php

src/Widget/ButtonGroup.php

CHANGELOG.md

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

This reverts commit d58950a.

Copilot

Pull request overview

Copilot reviewed 109 out of 109 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Attribute/Deprecated.php

tests/Attribute/DeprecatedTest.php

tests/Widget/RadioListTest.php

tests/Widget/ButtonGroupTest.php

tests/Tag/Base/NormalTagTest.php

tests/Widget/CheckboxListTest.php

tests/Tag/CustomTagTest.php

tests/Tag/Base/VoidTagTest.php

CHANGELOG.md

composer-require-checker.json

src/Attribute/Deprecated.php

CHANGELOG.md

Copilot

Pull request overview

Copilot reviewed 106 out of 106 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Tag/Base/NormalTag.php

src/Tag/Base/VoidTag.php

tests/Tag/BrTest.php

tests/Widget/RadioListTest.php

tests/Widget/CheckboxListTest.php

CHANGELOG.md

vjik

@razvbir Almost done. Can you add tests to keep test coverage 100%?

razvbir · 2026-03-11T12:50:59Z

@razvbir Almost done. Can you add tests to keep test coverage 100%?

@vjik Done. I added the tests. Test coverage is at 100%. Let me know if there's anything else I should do.

vjik · 2026-03-11T13:43:31Z

@razvbir Good job! Thank you for contribute.

Regular Expressions: Find: (\w+)::tag Replace: (new $1()) Apply razvbir's yiisoft/html#264 using regex Find: (\w+)::tag and Replace: (new $1()) Restructured psalm.xml: Find unused code = true. All error types have been categorized and will be reduced with the subsequent code reduction. 'UnusedParam' error detection has been completed.

razvbir and others added 6 commits March 4, 2026 22:19

Use new tagName() without parentheses instead of static contructor

c30b7c8

Use annotations instead of attributes for deprecation

8149d93

Revert "Use annotations instead of attributes for deprecation"

5c26f95

This reverts commit 8149d93.

Add message to deprications

1044c71

Modify build and change log

d58950a

This is drops support for php 8.1, 8.2, 8.3

Apply PHP CS Fixer and Rector changes (CI)

0388219

razvbir commented Mar 4, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

razvbir added 2 commits March 4, 2026 23:19

Add tests

487547a

This add tests that check that the static constructor has the Deprecated attribute

Merge branch 'master' of github.com:razvbir/html

50a9db7

razvbir marked this pull request as draft March 4, 2026 21:42

samdark requested a review from Copilot March 5, 2026 07:01

Copilot started reviewing on behalf of samdark March 5, 2026 07:01 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

src/Tag/Base/NormalTag.php Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

.github/workflows/build.yml Outdated Show resolved Hide resolved

samdark requested changes Mar 5, 2026

View reviewed changes

razvbir and others added 15 commits March 6, 2026 23:10

Update src/Widget/CheckboxList/CheckboxList.php

155c840

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update CHANGELOG.md

52e7923

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Tag/Base/NormalTag.php

a1e5aaa

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Tag/Base/VoidTag.php

ca0163d

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Tag/CustomTag.php

c13f890

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Widget/RadioList/RadioList.php

8d07325

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Update src/Widget/ButtonGroup.php

9fab09b

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>

Revert "Modify build and change log"

58191cb

This reverts commit d58950a.

CR Changes

65ac00e

Apply PHP CS Fixer and Rector changes (CI)

09d9c82

Apply PHP CS Fixer and Rector changes (CI)

cc41b17

Add parenthesis to missed cases

fe76b16

Add parenthesis to missed cases

d796ca7

Add parenthesis to missed cases

c953ad2

Add parenthesis to missed cases

881e97c

razvbir marked this pull request as ready for review March 7, 2026 19:08

razvbir requested a review from samdark March 7, 2026 19:09

samdark requested a review from Copilot March 9, 2026 16:26

Copilot started reviewing on behalf of samdark March 9, 2026 16:27 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

vjik requested changes Mar 9, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

composer-require-checker.json Outdated Show resolved Hide resolved

samdark requested changes Mar 9, 2026

View reviewed changes

src/Attribute/Deprecated.php Outdated Show resolved Hide resolved

razvbir and others added 5 commits March 10, 2026 21:28

Remove Deprecated polyfill

c660bc5

Merge branch 'master' of github.com:razvbir/html

12ead26

Apply PHP CS Fixer and Rector changes (CI)

09e670c

Improve CHANGELOG message and remove duplication

37b523b

Update composer-require-checker.json

d765cac

razvbir requested review from samdark and vjik March 10, 2026 19:53

samdark requested a review from Copilot March 10, 2026 20:46

Copilot started reviewing on behalf of samdark March 10, 2026 20:46 View session

samdark reviewed Mar 10, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Apply suggestions from code review

40a775d

samdark approved these changes Mar 10, 2026

View reviewed changes

Copilot AI reviewed Mar 10, 2026

View reviewed changes

src/Tag/Base/NormalTag.php Show resolved Hide resolved

src/Tag/Base/VoidTag.php Show resolved Hide resolved

tests/Tag/BrTest.php Show resolved Hide resolved

tests/Widget/RadioListTest.php Show resolved Hide resolved

tests/Widget/CheckboxListTest.php Show resolved Hide resolved

vjik approved these changes Mar 11, 2026

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

78ca707

vjik requested changes Mar 11, 2026

View reviewed changes

Add tests for static constructors

702ed52

vjik approved these changes Mar 11, 2026

View reviewed changes

vjik merged commit 3806168 into yiisoft:master Mar 11, 2026
24 checks passed

vjik mentioned this pull request Mar 11, 2026

Use new %TagClass%() instead of %TagClass%::tag() #243

Closed

Uh oh!

Conversation

razvbir commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vjik left a comment

Choose a reason for hiding this comment

Uh oh!

razvbir commented Mar 11, 2026

Uh oh!

vjik commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

razvbir commented Mar 4, 2026 •

edited

Loading

codecov bot commented Mar 4, 2026 •

edited

Loading