Skip to content

Start 4.0.0#266

Merged
vjik merged 7 commits intomasterfrom
4.0.0
Mar 13, 2026
Merged

Start 4.0.0#266
vjik merged 7 commits intomasterfrom
4.0.0

Conversation

@samdark
Copy link
Member

@samdark samdark commented Mar 13, 2026

#226

TODO:

  • Move changelog entries to 4.0.0.
  • Add UPGRADE.

Copilot AI review requested due to automatic review settings March 13, 2026 13:03
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e34f2d1) to head (56e8306).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #266   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       830       830           
===========================================
  Files             89        89           
  Lines           2231      2231           
===========================================
  Hits            2231      2231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces stricter validation for HTML tag IDs by rejecting an empty-string id value, adds a regression test for the new behavior, and documents the change in the changelog.

Changes:

  • Add runtime validation in Tag::id() to throw when $id === ''.
  • Add a PHPUnit test covering the empty-string ID case.
  • Add a changelog entry documenting the behavior change.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/Tag/Base/Tag.php Adds empty-string guard + exception in Tag::id().
tests/Tag/Base/TagTest.php Adds a test asserting an exception is thrown for id('').
CHANGELOG.md Documents the new Tag::id() behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vjik vjik changed the title 4.0.0 Start 4.0.0 Mar 13, 2026
@vjik vjik merged commit 645f562 into master Mar 13, 2026
26 checks passed
@vjik vjik deleted the 4.0.0 branch March 13, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants