Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 830 830
===========================================
Files 89 89
Lines 2231 2231
===========================================
Hits 2231 2231 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR introduces stricter validation for HTML tag IDs by rejecting an empty-string id value, adds a regression test for the new behavior, and documents the change in the changelog.
Changes:
- Add runtime validation in
Tag::id()to throw when$id === ''. - Add a PHPUnit test covering the empty-string ID case.
- Add a changelog entry documenting the behavior change.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Tag/Base/Tag.php |
Adds empty-string guard + exception in Tag::id(). |
tests/Tag/Base/TagTest.php |
Adds a test asserting an exception is thrown for id(''). |
CHANGELOG.md |
Documents the new Tag::id() behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vjik
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#226
TODO: