Skip to content

YPE-1846: Update to latest Bible app logo#205

Merged
cameronapak merged 6 commits intomainfrom
cp/YPE-1844-add-new-bible-app-logo-to-the-widgets
Mar 27, 2026
Merged

YPE-1846: Update to latest Bible app logo#205
cameronapak merged 6 commits intomainfrom
cp/YPE-1844-add-new-bible-app-logo-to-the-widgets

Conversation

@cameronapak
Copy link
Copy Markdown
Collaborator

@cameronapak cameronapak commented Mar 27, 2026

https://lifechurch.atlassian.net/browse/YPE-1846

Per our designer Tim Watson's directive, we are to update the Bible App logo across our BibleCard and VerseOfTheDay components.

CleanShot 2026-03-27 at 11 06 37@2x CleanShot 2026-03-27 at 11 05 38@2x

Refactor the BibleAppLogoLockup component to use `yv:text-foreground`
for better theme integration and update its dimensions to match the
SVG's intrinsic size. Also, adjust the verse-of-the-day component's
attribution text color to inherit from the parent's foreground color.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026

🦋 Changeset detected

Latest commit: 46b7075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@youversion/platform-react-ui Patch
@youversion/platform-core Patch
@youversion/platform-react-hooks Patch
vite-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cameronapak cameronapak changed the title YPE-1844: Update to latest Bible app logo YPE-1846: Update to latest Bible app logo Mar 27, 2026
Adds an SVG title element to the Bible
@cameronapak cameronapak marked this pull request as ready for review March 27, 2026 16:04
@cameronapak
Copy link
Copy Markdown
Collaborator Author

Hey @jaredhightower-youversion, can you review this?

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 27, 2026

Greptile Summary

This PR updates the Bible App logo used in BibleAppLogoLockup, which is rendered inside both the BibleCard and VerseOfTheDay components, to match the latest brand design provided by the designer.\n\nKey changes:\n- Replaces the SVG artwork with new paths, mask, and gradient definitions sized at 106×24 (up from 80×17).\n- Scoped gradient/mask IDs (bible-app-logo-lockup-gradient-a, -gradient-c, -mask) are preserved from the fixed state, avoiding cross-SVG ID collisions.\n- The color approach is improved: className is now computed with cn() so that callers can augment (not replace) the default yv:text-foreground yv:dark:text-(--yv-yellow-10) theme classes.\n- The {...props} spread is placed before the fixed xmlns / fill / className attributes, ensuring width, height, and viewBox remain overridable by consumers while defaults are still applied.\n- verse-of-the-day.tsx drops the now-redundant yv:text-black yv:dark:text-white from the attribution wrapper div since theming is handled inside the logo component itself.\n- The changeset correctly bumps all three packages together in accordance with the unified versioning policy.

Confidence Score: 5/5

Safe to merge — all previously flagged issues (missing viewBox, single-letter IDs) have been resolved, and the changes are well-scoped logo/theming updates.

No P0 or P1 issues found. Both prior review concerns were addressed: viewBox is present and correct, gradient/mask IDs are properly namespaced. The className merging pattern with cn() is sound, color theming is correctly moved into the component, and the changeset satisfies the unified versioning rule.

No files require special attention.

Important Files Changed

Filename Overview
packages/ui/src/components/bible-app-logo-lockup.tsx Updated SVG logo with new dimensions (106×24), proper scoped IDs (previously-flagged single-letter IDs resolved), improved className merging via cn(), and updated color scheme from text-black/white to text-foreground/yellow-10.
packages/ui/src/components/verse-of-the-day.tsx Removed redundant text-color classes from the attribution wrapper div, as color is now correctly managed inside BibleAppLogoLockup itself.
.changeset/green-walls-refuse.md Patch changeset correctly bumps all three packages together, satisfying the unified versioning requirement.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[BibleAppLogoLockup] -->|"cn('yv:text-foreground yv:dark:text-(--yv-yellow-10)', props.className)"| B[SVG 106×24]
    B --> C[Text path — fill=currentColor]
    B --> D[Mask — bible-app-logo-lockup-mask]
    D --> E[Gradient fill — gradient-a]
    B --> F[Masked group]
    F --> G[Background rect — gradient-c]
    F --> H[Cream shape — #FEF5EB]
    F --> I[Red bookmark — #FF3D4D]
    F --> J[Interior text — #FEF5EB]

    K[VerseOfTheDay] -->|showBibleAppAttribution| L[Wrapper div — no text-color classes]
    L --> A
Loading

Reviews (3): Last reviewed commit: "Merge branch 'main' into cp/YPE-1844-add..." | Re-trigger Greptile

cameronapak and others added 2 commits March 27, 2026 11:30
The `viewBox` attribute was missing from the SVG, which can cause
scaling issues in certain rendering contexts. Adding it ensures
consistent display.
Prevents cross-SVG ID collisions when multiple BibleAppLogoLockup
instances render on the same page (e.g. in BibleCard + VerseOfTheDay).

- a → bible-app-logo-lockup-gradient-a
- b → bible-app-logo-lockup-mask
- c → bible-app-logo-lockup-gradient-c

Amp-Thread-ID: https://ampcode.com/threads/T-019d3022-248c-76e8-b74b-00325ffcb0ff
Co-authored-by: Amp <amp@ampcode.com>
@cameronapak cameronapak merged commit 2a64020 into main Mar 27, 2026
6 checks passed
@cameronapak cameronapak deleted the cp/YPE-1844-add-new-bible-app-logo-to-the-widgets branch March 27, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants