YPE-1846: Update to latest Bible app logo#205
Conversation
Refactor the BibleAppLogoLockup component to use `yv:text-foreground` for better theme integration and update its dimensions to match the SVG's intrinsic size. Also, adjust the verse-of-the-day component's attribution text color to inherit from the parent's foreground color.
🦋 Changeset detectedLatest commit: 46b7075 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adds an SVG title element to the Bible
|
Hey @jaredhightower-youversion, can you review this? |
Greptile SummaryThis PR updates the Bible App logo used in Confidence Score: 5/5Safe to merge — all previously flagged issues (missing viewBox, single-letter IDs) have been resolved, and the changes are well-scoped logo/theming updates. No P0 or P1 issues found. Both prior review concerns were addressed: viewBox is present and correct, gradient/mask IDs are properly namespaced. The className merging pattern with cn() is sound, color theming is correctly moved into the component, and the changeset satisfies the unified versioning rule. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[BibleAppLogoLockup] -->|"cn('yv:text-foreground yv:dark:text-(--yv-yellow-10)', props.className)"| B[SVG 106×24]
B --> C[Text path — fill=currentColor]
B --> D[Mask — bible-app-logo-lockup-mask]
D --> E[Gradient fill — gradient-a]
B --> F[Masked group]
F --> G[Background rect — gradient-c]
F --> H[Cream shape — #FEF5EB]
F --> I[Red bookmark — #FF3D4D]
F --> J[Interior text — #FEF5EB]
K[VerseOfTheDay] -->|showBibleAppAttribution| L[Wrapper div — no text-color classes]
L --> A
Reviews (3): Last reviewed commit: "Merge branch 'main' into cp/YPE-1844-add..." | Re-trigger Greptile |
The `viewBox` attribute was missing from the SVG, which can cause scaling issues in certain rendering contexts. Adding it ensures consistent display.
Prevents cross-SVG ID collisions when multiple BibleAppLogoLockup instances render on the same page (e.g. in BibleCard + VerseOfTheDay). - a → bible-app-logo-lockup-gradient-a - b → bible-app-logo-lockup-mask - c → bible-app-logo-lockup-gradient-c Amp-Thread-ID: https://ampcode.com/threads/T-019d3022-248c-76e8-b74b-00325ffcb0ff Co-authored-by: Amp <amp@ampcode.com>
https://lifechurch.atlassian.net/browse/YPE-1846
Per our designer Tim Watson's directive, we are to update the Bible App logo across our BibleCard and VerseOfTheDay components.