Conversation
|
I believe that the current failure on the added test is legit and shows the failures I was seeing before my changes in the other PR. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryThis PR adds a new GitHub Actions workflow ( Confidence Score: 5/5Safe to merge — the workflow is well-structured with all previously raised concerns (timeout, permissions, Gradle caching, working directory) addressed. All P1 findings from prior review rounds have been resolved. The only remaining finding is a P2 style suggestion (missing No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GH as GitHub (PR to main)
participant Runner as ubuntu-latest Runner
participant Node as Node.js 20
participant Java as Java 17 (temurin)
participant Expo as Expo CLI (prebuild)
participant Gradle as Gradle (assembleDebug)
GH->>Runner: Trigger on pull_request
Runner->>Runner: Checkout repository
Runner->>Node: Setup Node.js 20 + npm cache
Runner->>Java: Setup Java 17 + Gradle cache
Runner->>Node: npm ci (root deps)
Runner->>Node: npm ci (example/ deps)
Runner->>Expo: npx expo prebuild (generates android/ + ios/)
Runner->>Gradle: ./gradlew assembleDebug (example/android)
Gradle-->>Runner: Build success / failure
Reviews (3): Last reviewed commit: "fix: cache and build" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Cameron Llewellyn <cameron.b.llewellyn@gmail.com>
bmanquen
left a comment
There was a problem hiding this comment.
I am learning about android and iOS so take my comments with a grain of salt.
|
Also I think we can probably test the android and ios builds in one github workflow file as long as they are in different jobs. |
|
|
||
| - name: Build Android app | ||
| working-directory: example/android | ||
| run: ./gradlew assembleDebug --no-daemon |
There was a problem hiding this comment.
This works! You could also set the working-directory to example and run npm run android.
There was a problem hiding this comment.
When I did that in CI it failed because there was no simulator device.
| working-directory: example | ||
| run: npm ci | ||
|
|
||
| - name: Prebuild Expo app |
There was a problem hiding this comment.
Actually, this could also (similar to iOS) be simplified to 1 command: npm run android. It will handle prebuild (creating the Android native directory) and building the app.
There was a problem hiding this comment.
I will try this again but I think doing this it was having issues with building since no simulator exists.
Description
We had broken example app builds. This adds the tests to build the Android app.
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist