chore: Upgrade Kotlin side to match YouVersion Kotlin SDK 1.0.1#41
Open
sidorchukandrew wants to merge 6 commits intomainfrom
Open
chore: Upgrade Kotlin side to match YouVersion Kotlin SDK 1.0.1#41sidorchukandrew wants to merge 6 commits intomainfrom
sidorchukandrew wants to merge 6 commits intomainfrom
Conversation
bbb2e6f to
47a6d7c
Compare
310c869 to
60270f8
Compare
cameronapak
reviewed
Mar 19, 2026
Collaborator
|
@greptileai, can you please review this PR? |
Contributor
Greptile SummaryThis PR upgrades the YouVersion Kotlin SDK from Key changes:
Minor items to clean up:
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant RN as React Native (JS)
participant Module as RNYouVersionPlatformModule
participant BibleApi as YVPBibleApi
participant LangApi as YVPLanguagesApi
participant SDK as YouVersionApi (SDK 1.0.1)
RN->>Module: chapter(bibleReference)
Module->>BibleApi: chapter(bibleReference)
BibleApi->>SDK: bible.passage(versionId, passageId)
SDK-->>BibleApi: PassageResponse { content }
BibleApi-->>Module: response.content (String)
Module-->>RN: String
RN->>Module: versions(languageTag)
Module->>BibleApi: versions(languageTag)
loop Paginate until nextPageToken == null
BibleApi->>SDK: bible.versions(languageTag, pageToken)
SDK-->>BibleApi: PagedResponse { data, nextPageToken }
end
BibleApi-->>Module: List<BibleVersionRecord>
Module-->>RN: List
RN->>Module: languages(country)
Module->>LangApi: languages(country)
loop Paginate until nextPageToken == null
LangApi->>SDK: languages.languages(country, pageToken)
SDK-->>LangApi: PagedResponse { data, nextPageToken }
end
LangApi-->>Module: List<LanguageRecord>
Module-->>RN: List
Reviews (3): Last reviewed commit: "chore: clean up unused imports and argum..." | Re-trigger Greptile |
android/src/main/java/com/youversion/reactnativesdk/api/YVPBibleApi.kt
Outdated
Show resolved
Hide resolved
43cd979 to
091d2a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does 2 things:
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Checklist