ZEP-0010: Vendoring external dependencies#11
Conversation
| Vendoring adds to repository's size. However, disk space is inexpensive, and many | ||
| large projects (eg. [Kubernetes](https://github.com/kubernetes/kubernetes/), with | ||
| a `vendor/` directory ~70MB) have benefited from improving their dependency management. | ||
| For Zarf, vendoring would increase the repository size by approximately 410MB. |
There was a problem hiding this comment.
I would be interested to see the cost of a vendor folder storage on the .git folder. I'm not sure if there is an easy way to calculate that. The Kubernetes .git folder is ~1.2 GBs. There have surely been a lot of changes in Kubernetes itself, but I wonder how much of .git folder is from vendor diffs.
There was a problem hiding this comment.
I did some research on the topic, but it's hard to clearly identify what the increase will be, since it will depend on the amount and size of changes over time. Because the history is the biggest contributor to the overall size of .git/ directory. I've added wording explicitly covering that dir.
| 3. **Faster CI/CD Builds Times.** | ||
|
|
||
| Local dependencies eliminate the need to fetch external dependencies, speeding | ||
| up builds. |
There was a problem hiding this comment.
This is especially nice for Windows builds, where github actions caching doesn't work, so pulling all the Zarf dependencies for unit tests takes about 10 minutes
soltysh
changed the title
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
Signed-off-by: Maciej Szulik <maciej@defenseunicorns.com>
| reviewers: | ||
| - "@daveworth" | ||
| - "@schristoff" | ||
| approvers: | ||
| - "@daveworth" | ||
| - "@schristoff" |
There was a problem hiding this comment.
| reviewers: | |
| - "@daveworth" | |
| - "@schristoff" | |
| approvers: | |
| - "@daveworth" | |
| - "@schristoff" | |
| reviewers: | |
| - "@daveworth" | |
| - "@zarf-dev/maintainers" | |
| approvers: | |
| - "@daveworth" | |
| - "@zarf-dev/maintainers" |
AustinAbro321
left a comment
AustinAbro321
left a comment
There was a problem hiding this comment.
zep.yaml needs a few updates. Strategy wise this looks good to me
There was a problem hiding this comment.
Should update the title and milestone versions here
3 participants
One-line PR description: Vendoring external dependencies
Issue link: Vendoring external dependencies #10