feat: support helm charts in kustomizations#4582
feat: support helm charts in kustomizations#4582vincent-onebrief wants to merge 1 commit intozarf-dev:mainfrom
Conversation
Signed-off-by: vincent-onebrief <vincent@onebrief.com>
✅ Deploy Preview for zarf-docs canceled.
|
|
Added tests fail as expected with |
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
| if enableKustomizePlugins { | ||
| buildOptions.PluginConfig = krustytypes.MakePluginConfig(krustytypes.PluginRestrictionsNone, krustytypes.BploUseStaticallyLinked) | ||
| buildOptions.PluginConfig.HelmConfig.Enabled = true | ||
| buildOptions.PluginConfig.HelmConfig.Command = "helm" |
There was a problem hiding this comment.
I half wonder if after #4350 is merged we should update this to use zarf tools helm.
Not a blocker, but a potential follow-up pr.
There was a problem hiding this comment.
Yeah, #4350 is close but blocked by a bug in Helm that will be fixed in the next Helm release.
I do think we should block this PR on that, the quasi Helm fork currently in Zarf is outdated, and I would like to avoid relying on the host binary, so that package builds are the same across devices
|
Marking this as blocked by #4350 which will fully embed Helm into the Zarf binary and should allow this to be done looking for the host binary |
Description
Currently kustomizations with helm chart references fail, even with plugins enabled.
This can be worked around with an onCreate action that renders the manifests, but that's kinda jank and breaks
zarf dev inspectandzarf dev find-images.This PR enables helm inside kustomizations when
enableKustomizePluginsis set, and adds tests to validate functionalityChecklist before merging