Skip to content

feat: enable plugin support for vender-ed kubectl#4705

Merged
brandtkeller merged 7 commits intomainfrom
feature/allen/kubectl-plugins
Apr 2, 2026
Merged

feat: enable plugin support for vender-ed kubectl#4705
brandtkeller merged 7 commits intomainfrom
feature/allen/kubectl-plugins

Conversation

@a1994sc
Copy link
Copy Markdown
Contributor

@a1994sc a1994sc commented Mar 12, 2026

Description

This update enables zarf tools kubectl to use kubectl plugins, tested with the following:

kubectl-cnpg
kubectl-get_all

Related Issue

Relates to #4681

Checklist before merging

@a1994sc
feat: fix logic for kubectl
b025d33 
Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc a1994sc requested review from a team as code owners March 12, 2026 00:04
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 12, 2026 •
edited
Loading

✅ Deploy Preview for zarf-docs ready!

Name Link
🔨 Latest commit c745e89
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69ce518b065b430008f52480
😎 Deploy Preview https://deploy-preview-4705--zarf-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 54.05405% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cmd/kubectl.go 58.06% 10 Missing and 3 partials ⚠️
src/cmd/vendor.go 33.33% 2 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
src/cmd/vendor.go 33.33% <33.33%> (+1.51%) ⬆️
src/cmd/kubectl.go 66.66% <58.06%> (-33.34%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

AustinAbro321
AustinAbro321 reviewed Mar 12, 2026
View reviewed changes
Comment thread src/cmd/kubectl.go Outdated
a1994sc added 2 commits March 12, 2026 15:47
@a1994sc
feat: update args offset
6da0eae 
Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc
feat: update logic for vendor-ed tools
2c77bf7 
Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc a1994sc requested a review from AustinAbro321 March 13, 2026 18:21
soltysh
soltysh reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to make this a little less brittle and easier to the reader 😉

Comment thread src/cmd/kubectl.go Outdated
Comment thread src/cmd/kubectl.go
Comment thread src/cmd/kubectl.go
Comment thread src/cmd/kubectl.go
@soltysh soltysh self-assigned this Mar 20, 2026
a1994sc added 2 commits March 20, 2026 15:00
@a1994sc
chore: update kubectl per review
46107a4 
Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc
update the logic to be mor agnostic
ececcf4 
Signed-off-by: Allen Conlon <software@conlon.dev>
@a1994sc
Copy link
Copy Markdown
Contributor Author

a1994sc commented Mar 30, 2026

Hey @soltysh, I was wondering if you would be happy with reviewing this PR as is? I would like like submit a PR for the kubectl updates at a later point when I have a bit more bandwidth.

@a1994sc a1994sc requested a review from soltysh April 2, 2026 11:22
soltysh
soltysh approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes lgtm

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Apr 2, 2026

Hey @soltysh, I was wondering if you would be happy with reviewing this PR as is? I would like like submit a PR for the kubectl updates at a later point when I have a bit more bandwidth.

Yeah, let's land this as is and deal with kubectl separately.

brandtkeller
brandtkeller approved these changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the argument offset logic is suitable for now but there still might be some room for additional testing/determinism (IE outlining if there is a difference between the helm stance versus here and possibly creating a common helper.

Otherwise lgtm.

@brandtkeller brandtkeller added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit d812a6b Apr 2, 2026
36 of 37 checks passed
@brandtkeller brandtkeller deleted the feature/allen/kubectl-plugins branch April 2, 2026 16:59
@github-project-automation github-project-automation Bot moved this to Done in Zarf Apr 2, 2026
@zarf-release-please zarf-release-please Bot mentioned this pull request Apr 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@brandtkeller brandtkeller brandtkeller approved these changes

@AustinAbro321 AustinAbro321 Awaiting requested review from AustinAbro321

Assignees

@soltysh soltysh

Labels

None yet

Projects

Zarf
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a1994sc @soltysh @AustinAbro321 @brandtkeller