Skip to content

fix: remove now-unneeded fill_value handling #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilan-gold merged 4 commits into from
Feb 16, 2026
Merged

fix: remove now-unneeded fill_value handling #149

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
079b669
fix: remove now-dead fill_value handling
ilan-gold Feb 12, 2026
f0c5947
fix: pre-commit
ilan-gold Feb 12, 2026
e550189
fix: imports
ilan-gold Feb 12, 2026
c29498c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions python/zarrs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
from typing import TYPE_CHECKING, Any

import numpy as np
from zarr.core.array_spec import ArraySpec
from zarr.core.indexing import SelectorTuple, is_integer
from zarr.core.indexing import is_integer

from zarrs._internal import ChunkItem

Expand All @@ -17,6 +16,8 @@
from types import EllipsisType

from zarr.abc.store import ByteGetter, ByteSetter
from zarr.core.array_spec import ArraySpec
from zarr.core.indexing import SelectorTuple
from zarr.dtype import ZDType


Expand Down Expand Up @@ -170,14 +171,6 @@ def make_chunk_info_for_rust_with_indices(
_,
) in batch_info:
write_empty_chunks = chunk_spec.config.write_empty_chunks
if chunk_spec.fill_value is None:
chunk_spec = ArraySpec(
chunk_spec.shape,
chunk_spec.dtype,
get_implicit_fill_value(chunk_spec.dtype, chunk_spec.fill_value),
chunk_spec.config,
chunk_spec.prototype,
)
out_selection_as_slices = selector_tuple_to_slice_selection(out_selection)
chunk_selection_as_slices = selector_tuple_to_slice_selection(chunk_selection)
shape_chunk_selection_slices = get_shape_for_selector(
Expand Down