Fix elseif / else indentation and support incomplete structures#42
Open
Fringale wants to merge 1 commit intozed-extensions:mainfrom
Open
Fix elseif / else indentation and support incomplete structures#42Fringale wants to merge 1 commit intozed-extensions:mainfrom
Fringale wants to merge 1 commit intozed-extensions:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36:
elseif/elsestatements are now correctly outdented, with the following line now also indented as expected.This PR leverages the
indent_patternconfiguration available to language extensions, similar to other extensions (Ruby, Python, Julia, Elixir) that work around tree-sitter indentation limitations.Additionally, it provides fallback indentation for control structures and function definitions when the syntax tree is temporarily incomplete (e.g. an
ifstatement without its closingend), which is especially useful when not using code snippets. These cases cannot yet be handled by tree-sitter alone. See the Julia extension for related rationale.