fix: enable addLeadingSpace for SentencePiece unigram models#5
Merged
Conversation
SetSentencePiece(true) now sets addLeadingSpace=true as a persistent field on BPETokenizer, matching llama.cpp / SentencePiece default behavior. Previously addLeadingSpace was only a parameter passed through the call chain — making it a field ensures the first word always gets the ▁ prefix prepended, so tokens like ▁What are found by the Viterbi DP instead of falling back to character-level tokens. Also adds SetAddLeadingSpace() for GGUF models that override the default via tokenizer.ggml.add_space_prefix metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetSentencePiece(true) now sets addLeadingSpace=true. Fixes ▁ prefix not being prepended, causing word tokens to not match vocab.