convert floating point stats from string#241
Open
louisadamian wants to merge 2 commits intozero-sum-seattle:mainfrom
Open
convert floating point stats from string#241louisadamian wants to merge 2 commits intozero-sum-seattle:mainfrom
louisadamian wants to merge 2 commits intozero-sum-seattle:mainfrom
Conversation
Member
|
I've gone ahead and removed the broken workflows and scripts that was causing the CI failure. Can you pull them down for the PR and run it? Also thank you for the PR :) |
212be05 to
36de8bc
Compare
Contributor
Author
|
Thanks, I merged in your upstream changes, but I can't trigger any workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert floating stats with decimal representation from str to float with pydantic
adds a
BeforeValidatorto base.py that converts types to float or returns none and anOptionalFloattype that used the validator and changed all the relevant types in stat objects.Tests
Passes all unit tests.