Skip to content

convert floating point stats from string#241

Open
louisadamian wants to merge 2 commits intozero-sum-seattle:mainfrom
louisadamian:convert_float_stats
Open

convert floating point stats from string#241
louisadamian wants to merge 2 commits intozero-sum-seattle:mainfrom
louisadamian:convert_float_stats

Conversation

@louisadamian
Copy link
Contributor

Convert floating stats with decimal representation from str to float with pydantic

adds a BeforeValidator to base.py that converts types to float or returns none and an OptionalFloat type that used the validator and changed all the relevant types in stat objects.

Tests

Passes all unit tests.

@Mattsface
Copy link
Member

I've gone ahead and removed the broken workflows and scripts that was causing the CI failure.

Can you pull them down for the PR and run it?

Also thank you for the PR :)

@louisadamian
Copy link
Contributor Author

Thanks, I merged in your upstream changes, but I can't trigger any workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants