Skip to content

Update Nameserver13#1505

Merged
tgreenx merged 2 commits intozonemaster:release/v2025.2.1from
tgreenx:fix-nameserver13
Mar 2, 2026
Merged

Update Nameserver13#1505
tgreenx merged 2 commits intozonemaster:release/v2025.2.1from
tgreenx:fix-nameserver13

Conversation

@tgreenx
Copy link
Contributor

@tgreenx tgreenx commented Feb 24, 2026

Purpose

This PR proposes to fix a discrepancy in the implementation of Nameserver13 with respect to its specification.

Context

Fixes #1503

Changes

How to test this PR

This test case (among others in this test module) currently have no unit test. See #1146.
Manual testing:

$ zonemaster-cli --show-testcase --level DEBUG --test nameserver13 --no-ipv6 afnic.fr | grep DNSKEY
   1.63 DEBUG    Nameserver13   System:Nameserver13:EXTERNAL_QUERY flags={"class":"IN","edns_details":{"do":1,"size":512,"version":0},"fallback":0,"usevc":0}; ip=194.0.36.1; name=afnic.fr; type=DNSKEY
   1.64 DEBUG    Nameserver13   IPv6 is disabled, not sending "DNSKEY" query to g.ext.nic.fr/2001:678:4c::1.
   1.64 DEBUG    Nameserver13   System:Nameserver13:EXTERNAL_QUERY flags={"class":"IN","edns_details":{"do":1,"size":512,"version":0},"fallback":0,"usevc":0}; ip=192.134.4.1; name=afnic.fr; type=DNSKEY
   1.65 DEBUG    Nameserver13   IPv6 is disabled, not sending "DNSKEY" query to ns1.nic.fr/2001:67c:2218:2::4:1.
   1.65 DEBUG    Nameserver13   System:Nameserver13:EXTERNAL_QUERY flags={"class":"IN","edns_details":{"do":1,"size":512,"version":0},"fallback":0,"usevc":0}; ip=192.93.0.4; name=afnic.fr; type=DNSKEY
   1.65 DEBUG    Nameserver13   IPv6 is disabled, not sending "DNSKEY" query to ns2.nic.fr/2001:660:3005:1::1:2.
   1.66 DEBUG    Nameserver13   System:Nameserver13:EXTERNAL_QUERY flags={"class":"IN","edns_details":{"do":1,"size":512,"version":0},"fallback":0,"usevc":0}; ip=192.134.0.49; name=afnic.fr; type=DNSKEY
   1.67 DEBUG    Nameserver13   IPv6 is disabled, not sending "DNSKEY" query to ns3.nic.fr/2001:660:3006:1::1:1.

@tgreenx tgreenx added this to the v2025.2.1 milestone Feb 24, 2026
@tgreenx tgreenx added A-TestCase Area: Test case specification or implementation of test case V-Patch Versioning: The change gives an update of patch in version. RC-Fixes Release category: Fixes. labels Feb 24, 2026
- Change query type to DNSKEY
- Add a mention for missing unit tests
@tgreenx tgreenx force-pushed the fix-nameserver13 branch from b03110b to 4102202 Compare March 2, 2026 13:36
marc-vanderwal
marc-vanderwal previously approved these changes Mar 2, 2026
@tgreenx tgreenx merged commit 429af65 into zonemaster:release/v2025.2.1 Mar 2, 2026
3 checks passed
@tgreenx tgreenx deleted the fix-nameserver13 branch March 2, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case RC-Fixes Release category: Fixes. V-Patch Versioning: The change gives an update of patch in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nameserver13 does not follow the test specification and queries for SOA instead of DNSKEY

3 participants