Update Nameserver13#1505
Merged
tgreenx merged 2 commits intozonemaster:release/v2025.2.1from Mar 2, 2026
Merged
Conversation
- Change query type to DNSKEY - Add a mention for missing unit tests
b03110b to
4102202
Compare
marc-vanderwal
previously approved these changes
Mar 2, 2026
marc-vanderwal
approved these changes
Mar 2, 2026
matsduf
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR proposes to fix a discrepancy in the implementation of Nameserver13 with respect to its specification.
Context
Fixes #1503
Changes
- Remove unneeded conditionals (relates to edns fails for afnic.fr ... seems to be false alert #480, which added checks related to Extended Error Codes but that were not necessary for this test case)How to test this PR
This test case (among others in this test module) currently have no unit test. See #1146.
Manual testing: